chore: remove dead isBunRuntime() export#943
Merged
MathurAditya724 merged 1 commit intomainfrom May 9, 2026
Merged
Conversation
The function lost its only caller in #938 when shouldUseLogging() stopped gating on the Bun runtime. Remove the definition and the stale test-file comment that referenced it.
Contributor
|
Contributor
Codecov Results 📊✅ 6837 passed | Total: 6837 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 13916 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 77.03% 77.04% +0.01%
==========================================
Files 317 317 —
Lines 60609 60608 -1
Branches 0 0 —
==========================================
+ Hits 46684 46692 +8
- Misses 13925 13916 -9
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isBunRuntime()function fromsrc/lib/init/ui/factory.ts— it lost its only caller in fix(init): enable interactive Ink UI for npx/Node via ESM sidecar #938 whenshouldUseLogging()stopped gating on the Bun runtimeFlagged by Cursor Bugbot in #938 (review).