refactor(dashboard): Tokenize structural UI colors - #1516
Draft
sentry-junior[bot] wants to merge 9 commits into
Draft
refactor(dashboard): Tokenize structural UI colors#1516sentry-junior[bot] wants to merge 9 commits into
sentry-junior[bot] wants to merge 9 commits into
Conversation
Move dashboard shell colors into root CSS tokens and replace hard-coded white/black/hex surfaces so a light theme can share the same utilities. Co-Authored-By: Nicholas Deschenes <nicholas.deschenes@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…tokens # Conflicts: # packages/junior-dashboard/src/client/App.tsx # packages/junior-dashboard/src/client/components/layout/DashboardHeader.tsx # packages/junior-dashboard/src/client/components/layout/SecondaryNavigation.tsx # packages/junior-dashboard/src/client/conversations/ConversationHeader.tsx # packages/junior-dashboard/src/client/conversations/ConversationPage.tsx # packages/junior-dashboard/src/client/conversations/ConversationSidebar.tsx # packages/junior-dashboard/src/client/conversations/ConversationTranscript.tsx # packages/junior-dashboard/src/client/conversations/PendingMailboxStack.tsx # packages/junior-dashboard/src/client/conversations/TranscriptActivityGroup.tsx # packages/junior-dashboard/src/client/conversations/TranscriptContextEventView.tsx # packages/junior-dashboard/src/client/conversations/TranscriptHeader.tsx # packages/junior-dashboard/src/client/conversations/TranscriptStructuredEventView.tsx # packages/junior-dashboard/src/client/conversations/TranscriptToolView.tsx
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
nsdeschenes
changed the title
![sentry-junior[bot]](https://avatars.githubusercontent.com/in/2960336?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Looks good to me. I checked the token values against the replaced dark-theme literals across the changed dashboard files, and the values and opacity variants match. The generated Tailwind CSS includes the new color, border, fill, chart, focus, and shadow utilities, with the remaining direct colors limited to status/data accents.
…tokens # Conflicts: # packages/junior-dashboard/src/client/conversations/ConversationHeader.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move dashboard structural colors into one root token set and point current surfaces at those tokens.
This is the groundwork for a light theme. Dark appearance stays the same. Status accents stay as Tailwind palette utilities.
What changed
packages/junior-dashboard/src/tailwind.css.dashboard-shell-bgcolor-schemeat--dashboard-color-schemefor later theme switchingChecks
pnpm --filter @sentry/junior-dashboard typecheckpnpm --filter @sentry/junior-dashboard lintpnpm --filter @sentry/junior-dashboard test(245 passed)Not included: a theme toggle, light palette values, or Shiki theme switching.
Requested by Nick.
--
View Junior Session [Sentry]