fix(slack): Prefer ids and known destinations for channel refs - #1596
Open
sentry-junior[bot] wants to merge 3 commits into
Open
fix(slack): Prefer ids and known destinations for channel refs#1596sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Channel tool params now accept only id-bearing forms. Remove the conversations.list workspace scan and document the id-first rule. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Plain channel names may match one stored junior_destinations display name in the current workspace. Keep id-first resolution and never scan Slack conversations.list. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
dcramer
marked this pull request as ready for review
August 16, 2026 02:06
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a6f518. Configure here.
Raise the channel ref max length so <#C…|name> forms with full-length channel names are not rejected before id parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plain channel names used to resolve through a
conversations.listworkspace scan with an arbitrary 1,000-channel cap. That path is slow, incomplete, and the wrong product shape.Channel tool params now resolve in this order:
C123,<#C123>,<#C123|name>,slack:C123junior_destinations.display_name)No
conversations.listcrawl. Ambiguous local names fail closed.Policy
policies/tool-design.md: prefer provider ids/native mentions; plain names may use local known state onlyVerification
pnpm --filter @sentry/junior exec vitest run tests/unit/slack/slack-ids.test.ts tests/integration/slack-channel-tools.test.ts tests/component/conversation-sql-store.test.ts tests/unit/services/turn-session-routing.test.ts— 53 passedpnpm --filter @sentry/junior typecheckgit diff --checkRequested by David Cramer.
--
View Junior Session [Sentry]