Skip to content

feat(config): resolve ${file:...} and ${VAR} references in config - #599

Open
matt-codecov wants to merge 1 commit into
matth/storage-inventory-tracker-4from
matth/serde-vars-config
Open

feat(config): resolve ${file:...} and ${VAR} references in config#599
matt-codecov wants to merge 1 commit into
matth/storage-inventory-tracker-4from
matth/serde-vars-config

Conversation

@matt-codecov

Copy link
Copy Markdown
Contributor

GCP secrets are mounted as files. this is what i did to load JWT keys in Relay's config, and it's more ergonomic than what i did for JWT keys in our own config. this will be used to load Kafka auth params


Stack created with GitHub Stacks CLIGive Feedback 💬

@matt-codecov
matt-codecov requested a review from a team as a code owner August 11, 2026 23:40
Comment thread objectstore-server/src/config.rs
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (329169e) to head (3ab8e17).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           matth/storage-inventory-tracker-4     #599      +/-   ##
=====================================================================
+ Coverage                              88.46%   88.53%   +0.07%     
=====================================================================
  Files                                    104      104              
  Lines                                  17162    17277     +115     
=====================================================================
+ Hits                                   15182    15297     +115     
  Misses                                  1980     1980              
Components Coverage Δ
Rust Backend 92.55% <100.00%> (+0.06%) ⬆️
Rust Client 81.97% <ø> (ø)
Python Client 93.31% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 476aa6d. Configure here.

Comment thread objectstore-server/src/config.rs
Comment thread objectstore-server/src/config.rs
@matt-codecov
matt-codecov force-pushed the matth/serde-vars-config branch from 476aa6d to a012388 Compare August 12, 2026 16:47
@matt-codecov
matt-codecov force-pushed the matth/serde-vars-config branch from a012388 to 3ab8e17 Compare August 15, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant