feat(eap): Calculate performance scores for V2 spans#5947
Draft
loewenheim wants to merge 6 commits intomasterfrom
Draft
feat(eap): Calculate performance scores for V2 spans#5947loewenheim wants to merge 6 commits intomasterfrom
loewenheim wants to merge 6 commits intomasterfrom
Conversation
loewenheim
commented
May 6, 2026
|
|
||
| measurements.insert( | ||
| measurements.insert_measurement( | ||
| format!("score.ratio.{}", component.measurement), |
Contributor
Author
There was a problem hiding this comment.
Here we would ideally use something more principled than just stitching an attribute together manually. See #5940 for a potential solution.
Dav1dde
reviewed
May 6, 2026
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Didn't think it would fit that easily, nice.
For:
ctx.project_info.config().performance_score.as_ref(),I had this comment which github doesn't let me save:
I did move a bunch of these to the top and gave it names, so all the normalize calls are on a single line. I liked the readability.
|
|
||
| measurements.insert( | ||
| measurements.insert_measurement( | ||
| format!("score.ratio.{}", component.measurement), |
Member
|
@loewenheim for tests, it would be great if you could update the |
Contributor
Author
Sure, will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly generalizes
normalize_performance_scoreso it can be applied to V2 spans (essentially all that needs to be done is to make it accessAttributesin addition toMeasurements).As the included tests demonstrate, this works seamlessly, with the minor wrinkle that the conditions for performance profiles need to be adjusted so that they match the browser name in either
event.context.browser.name(the status quo, for legacy events/spans) orspan.attributes.browser.name.value(for V2 spans). This should be simple enough to do in Sentry and is, in my opinion, vastly preferable to creating a compatibility shim in Relay itself.TODO:
ref: INGEST-844.