Skip to content

feat(core, node): portable Express integration #19928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacs wants to merge 2 commits into
base: develop
Choose a base branch
from
+2,691 −280
Open

feat(core, node): portable Express integration #19928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3877eb7
core: add wrapMethod util
isaacs Mar 20, 2026
ad38395
feat(core, node): portable Express integration
isaacs Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/nestjs-11/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
'express.name': '/test-transaction',
'express.type': 'request_handler',
'http.route': '/test-transaction',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
Copy link
Copy Markdown
Member

@Lms24 Lms24 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment on the origin change (not just this specific line): I looked up (with Hex) if any alerts, dashboards or saved explore queries depend on sentry.origin (or span.origin which is what the product maps the attribute to for better or worse):

  • Looks like no alerts are configured ✅
  • only 10 dashboard widgets depend on any sentry.origin attributes. All of these are set on the same dashboard for the same org and none depend directly on auto.http.otel.express ✅
  • No discover queries (though Discover is a legacy feature anyway) ✅
  • I didn't yet find any data for saved explore queries, so we're flying blind here for the moment. My guess is usage will be very low/non-existing.

Which means that I think it's fine to change the value now. No need to wait for a new major. Will try to get some more information on saved explore queries but this shouldn't block us.

'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
Expand All @@ -72,7 +72,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
status: 'ok',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
},
{
data: {
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/nestjs-8/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
'express.name': '/test-transaction',
'express.type': 'request_handler',
'http.route': '/test-transaction',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
Expand All @@ -76,7 +76,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
status: 'ok',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
},
{
data: {
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/nestjs-basic/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
'express.name': '/test-transaction',
'express.type': 'request_handler',
'http.route': '/test-transaction',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
Expand All @@ -72,7 +72,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
status: 'ok',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
},
{
data: {
Expand Down
4 changes: 2 additions & 2 deletions ...s/e2e-tests/test-applications/nestjs-with-submodules-decorator/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
'express.name': '/example-module/transaction',
'express.type': 'request_handler',
'http.route': '/example-module/transaction',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
Expand All @@ -72,7 +72,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
status: 'ok',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
},
{
data: {
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/nestjs-with-submodules/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
'express.name': '/example-module/transaction',
'express.type': 'request_handler',
'http.route': '/example-module/transaction',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
Expand All @@ -72,7 +72,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
status: 'ok',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
},
{
data: {
Expand Down
12 changes: 6 additions & 6 deletions dev-packages/e2e-tests/test-applications/node-express-cjs-preload/tests/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ test('Should record a transaction for route with parameters', async ({ request }
data: {
'express.name': 'query',
'express.type': 'middleware',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
},
op: 'middleware.express',
description: 'query',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -83,12 +83,12 @@ test('Should record a transaction for route with parameters', async ({ request }
data: {
'express.name': 'expressInit',
'express.type': 'middleware',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
},
op: 'middleware.express',
description: 'expressInit',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -102,12 +102,12 @@ test('Should record a transaction for route with parameters', async ({ request }
'express.name': '/test-transaction/:param',
'express.type': 'request_handler',
'http.route': '/test-transaction/:param',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
description: '/test-transaction/:param',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand Down
12 changes: 6 additions & 6 deletions dev-packages/e2e-tests/test-applications/node-express-esm-loader/tests/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ test('Should record a transaction for route with parameters', async ({ request }
data: {
'express.name': 'query',
'express.type': 'middleware',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
},
op: 'middleware.express',
description: 'query',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -83,12 +83,12 @@ test('Should record a transaction for route with parameters', async ({ request }
data: {
'express.name': 'expressInit',
'express.type': 'middleware',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
},
op: 'middleware.express',
description: 'expressInit',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -102,12 +102,12 @@ test('Should record a transaction for route with parameters', async ({ request }
'express.name': '/test-transaction/:param',
'express.type': 'request_handler',
'http.route': '/test-transaction/:param',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
description: '/test-transaction/:param',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand Down
12 changes: 6 additions & 6 deletions dev-packages/e2e-tests/test-applications/node-express-esm-preload/tests/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ test('Should record a transaction for route with parameters', async ({ request }
data: {
'express.name': 'query',
'express.type': 'middleware',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
},
op: 'middleware.express',
description: 'query',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -83,12 +83,12 @@ test('Should record a transaction for route with parameters', async ({ request }
data: {
'express.name': 'expressInit',
'express.type': 'middleware',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
},
op: 'middleware.express',
description: 'expressInit',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -102,12 +102,12 @@ test('Should record a transaction for route with parameters', async ({ request }
'express.name': '/test-transaction/:param',
'express.type': 'request_handler',
'http.route': '/test-transaction/:param',
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
},
op: 'request_handler.express',
description: '/test-transaction/:param',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/node-express-v5/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ test('Sends an API route transaction', async ({ baseURL }) => {
// auto instrumented span
expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
'http.route': '/test-transaction',
'express.name': '/test-transaction',
'express.type': 'request_handler',
},
description: '/test-transaction',
op: 'request_handler.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand Down
25 changes: 12 additions & 13 deletions dev-packages/e2e-tests/test-applications/node-express/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ test('Sends an API route transaction', async ({ baseURL }) => {
// auto instrumented spans
expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
'express.name': 'query',
'express.type': 'middleware',
},
description: 'query',
op: 'middleware.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -103,14 +103,14 @@ test('Sends an API route transaction', async ({ baseURL }) => {

expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
'express.name': 'expressInit',
'express.type': 'middleware',
},
description: 'expressInit',
op: 'middleware.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -121,15 +121,15 @@ test('Sends an API route transaction', async ({ baseURL }) => {

expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
'http.route': '/test-transaction',
'express.name': '/test-transaction',
'express.type': 'request_handler',
},
description: '/test-transaction',
op: 'request_handler.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand Down Expand Up @@ -161,14 +161,14 @@ test('Sends an API route transaction for an errored route', async ({ baseURL })

expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
'express.name': 'query',
'express.type': 'middleware',
},
description: 'query',
op: 'middleware.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -179,14 +179,14 @@ test('Sends an API route transaction for an errored route', async ({ baseURL })

expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'middleware.express',
'express.name': 'expressInit',
'express.type': 'middleware',
},
description: 'expressInit',
op: 'middleware.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
Expand All @@ -197,22 +197,21 @@ test('Sends an API route transaction for an errored route', async ({ baseURL })

expect(spans).toContainEqual({
data: {
'sentry.origin': 'auto.http.otel.express',
'sentry.origin': 'auto.http.express',
'sentry.op': 'request_handler.express',
'http.route': '/test-exception/:id',
'express.name': '/test-exception/:id',
'express.type': 'request_handler',
},
description: '/test-exception/:id',
op: 'request_handler.express',
origin: 'auto.http.otel.express',
origin: 'auto.http.express',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
status: 'internal_error',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
measurements: {},
});
});

Expand Down
Loading
Loading