feat(server-utils): Expose channel-based, streamlined fastifyIntegration#21706
Open
mydea wants to merge 9 commits into
Open
feat(server-utils): Expose channel-based, streamlined fastifyIntegration#21706mydea wants to merge 9 commits into
fastifyIntegration#21706mydea wants to merge 9 commits into
Conversation
mydea
changed the title
fastifyIntegration
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
faecc64 to
7edd803
Compare
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
Member
Author
|
@isaacs we can likely also use this as-is in deno and bun (IMHO we can do that in a follow up) |
Contributor
|
👋 @JPeer264, @andreiborza — Please review this PR when you get a chance! |
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
7edd803 to
64f53cd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 64f53cd. Configure here.
andreiborza
approved these changes
Jun 29, 2026
mydea
force-pushed
the
ref/streamline-fastify-otel-vendored
branch
from
64f53cd to
fbe0085
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+303
to
+311
| setNotFoundHandlerOriginal.call( | ||
| this, | ||
| hooks, | ||
| handlerWrapper(handler, 'notFoundHandler', { | ||
| [ATTRIBUTE_HOOK_NAME]: `${this.pluginName} - not-found-handler`, | ||
| [ATTRIBUTE_FASTIFY_TYPE]: HOOK_TYPE_INSTANCE, | ||
| [ATTRIBUTE_HOOK_CALLBACK_NAME]: handler.name?.length > 0 ? handler.name : ANONYMOUS_FUNCTION_NAME, | ||
| }), | ||
| ); |
Contributor
There was a problem hiding this comment.
Bug: The setNotFoundHandlerPatched function doesn't guard against an undefined handler before wrapping it, leading to a TypeError when the 404 handler is invoked.
Severity: HIGH
Suggested Fix
Add a guard in setNotFoundHandlerPatched to check if handler is undefined. If it is, avoid wrapping it and instead pass undefined directly to the original setNotFoundHandler.call().
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/server-utils/src/integrations/tracing-channel/fastify/instrumentation.ts#L303-L311
Potential issue: The patched function `setNotFoundHandlerPatched` unconditionally wraps
the optional `handler` argument. Fastify's API allows calling `setNotFoundHandler` with
only a hooks object and no handler, which results in the `handler` argument being
`undefined`. When a 404 request is subsequently processed, the wrapper function attempts
to execute `handler.call(this, ...args)`, which will throw a `TypeError` because
`handler` is `undefined`. This crash occurs under valid and documented API usage for
Fastify.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of #20745, streamlining fastify v5 instrumentation:
Some other general notes:
instrumentFastifymethod and no longer calls it in preload, as this does not actually need to be preloaded anymore.