Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion packages/core/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
*/
public on(hook: 'beforeEnvelope', callback: (envelope: Envelope) => void): () => void;

/**
* Register a callback for after an envelope has been accepted by the transport.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'afterEnvelope', callback: (envelope: Envelope) => void): () => void;

/**
* Register a callback that runs when stack frame metadata should be applied to an event.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand Down Expand Up @@ -881,6 +887,14 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
*/
public on(hook: 'flush', callback: () => void): () => void;

/**
* A hook that is called when spans of a single trace should be flushed eagerly,
* ahead of the trace's regular flush point. Only runtimes with a span streaming
* buffer (e.g. the Cloudflare SDK) listen to this hook.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'flushTraceSpans', callback: (traceId: string) => void): () => void;

/**
* A hook that is called when the client is closing
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand Down Expand Up @@ -1051,6 +1065,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
*/
public emit(hook: 'beforeEnvelope', envelope: Envelope): void;

/**
* Fire a hook event after an envelope has been accepted by the transport.
*/
public emit(hook: 'afterEnvelope', envelope: Envelope): void;

/**
* Fire a hook indicating that stack frame metadata should be applied to the event passed to the hook.
*/
Expand Down Expand Up @@ -1175,6 +1194,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
*/
public emit(hook: 'flush'): void;

/**
* Fire a hook event indicating that spans of a single trace should be flushed eagerly.
*/
public emit(hook: 'flushTraceSpans', traceId: string): void;

/**
* Emit a hook event for client close
*/
Expand Down Expand Up @@ -1258,7 +1282,9 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {

if (this._isEnabled() && this._transport) {
try {
return await this._transport.send(envelope);
const result = await this._transport.send(envelope);
this.emit('afterEnvelope', envelope);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully sure why we need this hook yet. Is the idea that we basically do

cloudflareClient.on('afterEnvelope', () => {
  // potentially with a setTimeout for a grace period or something similar
  cloudflareClient.emit('flushTraceSpans', traceId);
})

?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly. No sure if there is a better solution for this

return result;
} catch (reason) {
DEBUG_BUILD && debug.error('Error while sending envelope:', reason);
return {};
Expand Down
6 changes: 6 additions & 0 deletions packages/core/src/integrations/spanStreaming.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ export const spanStreamingIntegration = defineIntegration(() => {
}
buffer.add(captureSpan(span, client));
});

// Lets runtimes flush a single trace eagerly (e.g. the Cloudflare SDK draining
// a trace the moment its segment ends), without exposing the buffer itself.
client.on('flushTraceSpans', traceId => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine since browser ships its own spanStreamingIntegration and thus we don't bloat a browser bundle with this logic.

@JPeer264 JPeer264 Aug 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counter question. Is it safe to flush at any point in time?

FWIW I'm currently testing if we can get rid of this option actually.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lms24 just tried to move it over to Sentry.flush directly and it seems under load on deployed workers only half of the traces were received.

After putting some thoughts into it, it might be even bad (even if it would work) to run flush for all traces, as the flush is bound per request, which means one request could potentially suffer performance wise.

buffer.flush(traceId);
});
},
};
}) satisfies IntegrationFn;
19 changes: 19 additions & 0 deletions packages/core/test/integrations/spanStreaming.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,23 @@ describe('spanStreamingIntegration (core)', () => {

expect(mockSpanBufferInstance.add).not.toHaveBeenCalled();
});

it('flushes a single trace when the flushTraceSpans hook is emitted', () => {
const client = new TestClient({
...getDefaultTestClientOptions(),
dsn: 'https://username@domain/123',
integrations: [spanStreamingIntegration()],
traceLifecycle: 'stream',
tracesSampleRate: 1,
});

SentryCore.setCurrentClient(client);
client.init();

client.emit('flushTraceSpans', 'trace-1');

expect(mockSpanBufferInstance.flush).toHaveBeenCalledTimes(1);
expect(mockSpanBufferInstance.flush).toHaveBeenCalledWith('trace-1');
expect(mockSpanBufferInstance.drain).not.toHaveBeenCalled();
});
});
33 changes: 33 additions & 0 deletions packages/core/test/lib/client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3073,6 +3073,39 @@ describe('Client', () => {
client.emit('beforeEnvelope', mockEnvelope);
});

it('calls an afterEnvelope hook after the transport send resolves', async () => {
let resolveSend: (() => void) | undefined;
const sendPromise = new Promise<void>(resolve => {
resolveSend = resolve;
});
const client = new TestClient(
getDefaultTestClientOptions({
dsn: PUBLIC_DSN,
transport: () => ({
send: vi.fn().mockReturnValue(sendPromise),
flush: vi.fn().mockResolvedValue(true),
}),
}),
);
const mockEnvelope = [
{
event_id: '12345',
},
[],
] as Envelope;
const callback = vi.fn();
client.on('afterEnvelope', callback);

const result = client.sendEnvelope(mockEnvelope);
expect(callback).not.toHaveBeenCalled();

resolveSend?.();
await result;

expect(callback).toHaveBeenCalledOnce();
expect(callback).toHaveBeenCalledWith(mockEnvelope);
});

it('returns a cleanup function that, when executed, unregisters a hook', async () => {
vi.useFakeTimers();
expect.assertions(8);
Expand Down
Loading