fix(node): Move Async context strategy setup to NodeClient.init() - #23458
Open
timfish wants to merge 2 commits into
Open
fix(node): Move Async context strategy setup to NodeClient.init()#23458timfish wants to merge 2 commits into
timfish wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
timfish
marked this pull request as ready for review
August 20, 2026 00:41
timfish
requested review from
JPeer264,
Lms24,
msonnb and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
August 20, 2026 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDKs that can't reuse
@sentry/node'sinit()(see getsentry/sentry-electron#1415) currently have to copy this wiring themselves: install the strategy and assignclient.asyncLocalStorageLookup. With this change, constructing aNodeClientand callingclient.init()is enough, matching whatDenoClient.init()already does. The install runs beforesuper.init()because channel-based integrations capture the strategy'sAsyncLocalStorageviagetTracingChannelBinding()during integration setup.Nothing changes for existing consumers:
@sentry/node'sinit(), which still installs the strategy exactly once per init, now viaclient.init(). There are noNodeClientsubclasses.getDefaultCurrentScope(), the same object both server strategies fall back to, soinitialScopeandsetClientstill land on the same scope.NodeClientwithout callinginit#11585) previously got no strategy and noasyncLocalStorageLookupat all; now they get both.