Autoinstall Profiler#222
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Unused constant
DEFAULT_INSTALL_PROFILER_STRINGnever referenced- I added an
installProfiler@Parameter(defaultValue = DEFAULT_INSTALL_PROFILER_STRING)toExtensionConfigurationHolderMojo, which makes the constant used and exposes the configuration consistently.
- I added an
- ✅ Fixed: Default constant declared after instance field that uses it
- I moved
DEFAULT_INSTALL_PROFILERandDEFAULT_INSTALL_PROFILER_STRINGinto the top default-constants block before instance fields to match class ordering conventions.
- I moved
Or push these changes by commenting:
@cursor push 7458bc9470
Preview (7458bc9470)
diff --git a/src/main/java/io/sentry/ExtensionConfigurationHolderMojo.java b/src/main/java/io/sentry/ExtensionConfigurationHolderMojo.java
--- a/src/main/java/io/sentry/ExtensionConfigurationHolderMojo.java
+++ b/src/main/java/io/sentry/ExtensionConfigurationHolderMojo.java
@@ -1,5 +1,6 @@
package io.sentry;
+import static io.sentry.config.PluginConfig.DEFAULT_INSTALL_PROFILER_STRING;
import static io.sentry.config.PluginConfig.DEFAULT_SKIP_AUTO_INSTALL_STRING;
import static io.sentry.config.PluginConfig.DEFAULT_SKIP_TELEMETRY_STRING;
@@ -21,6 +22,10 @@
@Parameter(defaultValue = DEFAULT_SKIP_TELEMETRY_STRING)
private boolean skipTelemetry;
+ @SuppressWarnings("UnusedVariable")
+ @Parameter(defaultValue = DEFAULT_INSTALL_PROFILER_STRING)
+ private boolean installProfiler;
+
@Override
public void execute() throws MojoExecutionException, MojoFailureException {}
}
diff --git a/src/main/java/io/sentry/config/PluginConfig.java b/src/main/java/io/sentry/config/PluginConfig.java
--- a/src/main/java/io/sentry/config/PluginConfig.java
+++ b/src/main/java/io/sentry/config/PluginConfig.java
@@ -23,6 +23,8 @@
public static final boolean DEFAULT_SKIP_VALIDATE_SDK_DEPENDENCY_VERSIONS = false;
public static final @NotNull String DEFAULT_SKIP_VALIDATE_SDK_DEPENDENCY_VERSIONS_STRING =
"false";
+ public static final boolean DEFAULT_INSTALL_PROFILER = false;
+ public static final @NotNull String DEFAULT_INSTALL_PROFILER_STRING = "false";
public static final @NotNull String DEFAULT_ADDITIONAL_SOURCE_DIRS_FOR_SOURCE_CONTEXT = "";
private boolean skip = DEFAULT_SKIP;
@@ -38,9 +40,6 @@
DEFAULT_ADDITIONAL_SOURCE_DIRS_FOR_SOURCE_CONTEXT;
private boolean installProfiler = DEFAULT_INSTALL_PROFILER;
- public static final boolean DEFAULT_INSTALL_PROFILER = false;
- public static final @NotNull String DEFAULT_INSTALL_PROFILER_STRING = "false";
-
private @Nullable String org;
private @Nullable String project;
private @Nullable String url;| protected @Nullable Artifact findThirdPartyDependency( | ||
| final @NotNull List<Artifact> resolvedArtifacts) { | ||
| // Return a dummy artifact as there are no third-party dependencies required | ||
| return new DefaultArtifact("dummy:dummy:1.0.0"); |
There was a problem hiding this comment.
Looks fine as a workaround for now. We should consider a cleaner implementation if there's more of these in the future.
| <additionalSourceDirsForSourceContext> | ||
| <value>src/main/extra_param</value> | ||
| </additionalSourceDirsForSourceContext> | ||
| <installProfiler>false</installProfiler> |
There was a problem hiding this comment.
m why do we set it to false but show options for enabling profiling above?
| ### Features | ||
|
|
||
| - add option to ignore source bundle upload failures ([#209](https://github.com/getsentry/sentry-maven-plugin/pull/209)) | ||
| - Autoinstall Profiler ([#222](https://github.com/getsentry/sentry-maven-plugin/pull/222)) |
There was a problem hiding this comment.
We should mention the name of the option to enable it
…rsion check fails
…ity for skippedInstallMessage per install strategy
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d15cf76. Configure here.
…ady installed. not if disabled by config


📜 Description
Add a new flag
installProfilerto automatically install thesentry-async-profilerusing the maven plugin.💡 Motivation and Context
resolves: #221
💚 How did you test it?
📝 Checklist
🔮 Next steps