chore(billing): Created recurring credit and message protos(REVENG-251)#330
Open
krithikravi wants to merge 1 commit into
Open
chore(billing): Created recurring credit and message protos(REVENG-251)#330krithikravi wants to merge 1 commit into
krithikravi wants to merge 1 commit into
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
dashed
approved these changes
Jun 25, 2026
Comment on lines
+8
to
+14
| message GetActiveRecurringCreditsRequest { | ||
| uint64 organization_id = 1; | ||
| // Returns all recurring credits active at any point within | ||
| // [start_date, end_date], inclusive. | ||
| sentry_protos.billing.v1.Date start_date = 2; | ||
| sentry_protos.billing.v1.Date end_date = 3; | ||
| } |
Member
There was a problem hiding this comment.
let's have 2 endpoints. one for units and another for monetary recurring credits
| } | ||
|
|
||
| // A recurring gift or discount granted to an organization. | ||
| message RecurringCredit { |
Member
There was a problem hiding this comment.
Suggested change
| message RecurringCredit { | |
| message RecurringCreditEntry { |
It's a mix of RecurringCredit and RecurringCreditEntry models, but I think it makes more sense to call it RecurringCreditEntry for our purposes right now.
| // Amount granted for the billing period. Interpretation depends on type: | ||
| // UNITS -> unit quantity (billable metric base units), CENTS -> cents, | ||
| // DISCOUNT_PERCENT -> whole percent. | ||
| int64 amount = 4; |
Member
There was a problem hiding this comment.
Suggested change
| int64 amount = 4; | |
| uint64 amount = 4; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/getsentry/issue/REVENG-251/define-protobufs-for-recurring-credits
This PR defines the shape of a recurring credit, as well as endpoints to get, create, and cancel recurring credits. Cancellation is currently not supported in the legacy code, but it seems like a logical extension to add as part of this ticket.