fix(anthropic): Respect iterator protocol in asynchronous streamed responses#5675
Draft
alexander-alderman-webb wants to merge 12 commits intowebb/anthropic/sync-iteratorsfrom
Draft
fix(anthropic): Respect iterator protocol in asynchronous streamed responses#5675alexander-alderman-webb wants to merge 12 commits intowebb/anthropic/sync-iteratorsfrom
alexander-alderman-webb wants to merge 12 commits intowebb/anthropic/sync-iteratorsfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Anthropic
Pydantic Ai
Other
Bug Fixes 🐛Anthropic
Other
Documentation 📚
Internal Changes 🔧Anthropic
Docs
Openai Agents
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 31 passed | Total: 31 | Pass Rate: 100% | Execution Time: 10.26s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 15084 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 26.18% 27.02% +0.84%
==========================================
Files 189 189 —
Lines 20491 20668 +177
Branches 6702 6750 +48
==========================================
+ Hits 5364 5584 +220
- Misses 15127 15084 -43
- Partials 463 494 +31Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Close AI Client Spans when anthropic's HTTP connection is closed instead of when the GC collects the private
_iteratorinstance variable. Patch all methods that can close the connection.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)