ref(react-router): Install SDK package with version @^10#1303
Conversation
nicohrubec
left a comment
nicohrubec
left a comment
There was a problem hiding this comment.
thanks! so in all other wizards this is pinned already?
|
|
||
| ## Unreleased | ||
|
|
||
| - ref(react-router): Install SDK package with version `@^10` ([#1303](https://github.com/getsentry/sentry-wizard/pull/1303)) |
There was a problem hiding this comment.
afaik putting this here is optional so you can also omit it next time and then we add an auto-entry during release, just an fyi can leave as is 😅
yes! happened in #1048 already |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 96a11b6. Configure here.
|
|
||
| describe('ReactNative', () => { | ||
| // TODO: remove skipIf when macOS CI is fixed | ||
| describe.skipIf(process.platform === 'darwin')('ReactNative', () => { |
There was a problem hiding this comment.
Unrelated React Native test skip
Medium Severity
This PR is about pinning @sentry/react-router to @^10, but it also skips the entire React Native e2e suite on Darwin. That change is unrelated, unmentioned in the PR description or changelog, and disables macOS-only coverage such as pod install and the Xcode project test, which can never run while this skip is present.
Reviewed by Cursor Bugbot for commit 96a11b6. Configure here.
|
|
||
| describe('ReactNative', () => { | ||
| // TODO: remove skipIf when macOS CI is fixed | ||
| describe.skipIf(process.platform === 'darwin')('ReactNative', () => { |
There was a problem hiding this comment.
Skipped suite leaks temp directory
Low Severity
createIsolatedTestEnv runs in the describe body during collection, so it still creates and copies the React Native test app when the suite is skipped on Darwin. Cleanup lives only in afterAll, which Vitest does not run for skipped suites, so the temp directory is never removed.
Reviewed by Cursor Bugbot for commit 96a11b6. Configure here.
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Lets also create an issue to remind ourselves to unskip this.
3 participants
in preparation of the v11 major release, let's ensure we limit the installed SDK package version to latest v10. We'll bump to 11 post-release.
Only react-router and profiling-node are missing, the others have it already from when we released v10.
closes #1275