chore(workflow-engine): Modify cache utils to fix failing tests - #120747
Open
leeandher wants to merge 4 commits into
Open
Conversation
leeandher
force-pushed
the
leanderrodrigues/iswf-3123-test-fixes-for-migration
branch
from
July 28, 2026 17:04
43104fc to
196a710
Compare
Contributor
Sentry Snapshot Testing
|
leeandher
force-pushed
the
leanderrodrigues/iswf-3123-test-fixes-for-migration
branch
from
July 28, 2026 18:01
196a710 to
aef80fb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
leeandher
force-pushed
the
leanderrodrigues/iswf-3123-test-fixes-for-migration
branch
from
July 28, 2026 18:11
aef80fb to
081ffb5
Compare
leeandher
marked this pull request as ready for review
July 28, 2026 18:40
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 081ffb5. Configure here.
This reverts commit 026c9ea.
saponifi3d
reviewed
Jul 28, 2026
|
|
||
| def get_org_from_detector(detector: Detector) -> tuple[Organization]: | ||
| return (detector.linked_project.organization,) | ||
| def get_org_from_detector(detector: Detector) -> tuple[Organization] | None: |
Contributor
There was a problem hiding this comment.
rather than this returning none, can we raise an exception? My thought here is, I would expect every detector to belong to an org, and if it isn't then it should be treated as an error.
That would also mean that the function_cache wouldn't need to change 🎉 we'd just call into here, raise an unhandled exception, and catch that with sentry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The cascade deletions cause issues with these caching functions. The test failures can be seen in the migration PR. I'm not too familiar with these utilities but from my understanding:
I consulted claude about this ordering change, who added:
Previous PR: #120744
Next PR: #120687