fix(conversations): use user ID as display-name fallback - #120756
Open
fallintoplace wants to merge 1 commit into
Open
fix(conversations): use user ID as display-name fallback#120756fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ID-only users are valid conversation users, but the display helper ignored the ID field. These users therefore rendered as an unexplained dash even though identifying data was available.
Testing
pnpm exec jest static/app/views/explore/conversations/components/conversationsTable.spec.tsx --runInBandpnpm exec oxfmt --check static/app/views/explore/conversations/components/conversationsTable.tsx static/app/views/explore/conversations/components/conversationsTable.spec.tsxpnpm exec eslint static/app/views/explore/conversations/components/conversationsTable.tsx static/app/views/explore/conversations/components/conversationsTable.spec.tsx