fix(ourlogs): use the right range operator when paginating ascending logs - #120771
Open
JoshuaKGoldberg wants to merge 1 commit into
Open
Conversation
…logs `??` binds tighter than `?:`, so the page filter's comparison was really `querySortDirection ?? (sortByDirection === 'asc')`. `querySortDirection` is a `Sort` object, so it was always truthy when set and every sort-flipping page asked for `>=`.
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7c38bbe. Configure here.
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7c38bbe. Configure here.
JoshuaKGoldberg
marked this pull request as ready for review
July 28, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the logs table sorted by timestamp ascending, scrolling back to the top fetched the newest rows instead of older ones and prepended them above the oldest. When the result set already fit in one page, deduplication then left the previously-first row alone at the end of the list.
Closes LOGS-932.