feat(reporting): add configuredSkills roster to findings output - #473
Open
CalebKAston wants to merge 4 commits into
Open
feat(reporting): add configuredSkills roster to findings output#473CalebKAston wants to merge 4 commits into
CalebKAston wants to merge 4 commits into
Conversation
…portWorkflow options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
warden-findings.jsonexport lists what ran, but not what was configured to run — there's no way for a downstream consumer to distinguish "this skill has no findings because nothing was wrong" from "this skill never ran on this event." A schedule-only or local-only skill is invisible on every PR run, not just absent.This adds a top-level
configuredSkills: { name: string; triggered: boolean }[]field: the full roster of skills configured for the repo, each flagged with whether it actually triggered for this run.buildConfiguredSkillsListcomputes it from the full resolved-trigger set against the matched subset, deduping by name since a skill can have multiple trigger blocks (e.g. a PR trigger and a schedule trigger) that share one name.No schema change to existing fields: the field is new and optional, so existing consumers see no difference unless they read it.
Test plan
pnpm lint && pnpm build && pnpm test— all green (93 test files, 1833 passing, 4 pre-existing skips)buildConfiguredSkillsList's dedup/match/empty-input behavior, and a schedule-only skill correctly appearing as configured-but-not-triggered on a PR run