Skip to content

feat(reporting): add configuredSkills roster to findings output - #473

Open
CalebKAston wants to merge 4 commits into
getsentry:mainfrom
babylist:feat/upstream-configured-skills-roster
Open

feat(reporting): add configuredSkills roster to findings output#473
CalebKAston wants to merge 4 commits into
getsentry:mainfrom
babylist:feat/upstream-configured-skills-roster

Conversation

@CalebKAston

Copy link
Copy Markdown
Contributor

Summary

The warden-findings.json export lists what ran, but not what was configured to run — there's no way for a downstream consumer to distinguish "this skill has no findings because nothing was wrong" from "this skill never ran on this event." A schedule-only or local-only skill is invisible on every PR run, not just absent.

This adds a top-level configuredSkills: { name: string; triggered: boolean }[] field: the full roster of skills configured for the repo, each flagged with whether it actually triggered for this run. buildConfiguredSkillsList computes it from the full resolved-trigger set against the matched subset, deduping by name since a skill can have multiple trigger blocks (e.g. a PR trigger and a schedule trigger) that share one name.

No schema change to existing fields: the field is new and optional, so existing consumers see no difference unless they read it.

Test plan

  • pnpm lint && pnpm build && pnpm test — all green (93 test files, 1833 passing, 4 pre-existing skips)
  • Coverage for: the roster shape when provided, the field's absence when not provided, buildConfiguredSkillsList's dedup/match/empty-input behavior, and a schedule-only skill correctly appearing as configured-but-not-triggered on a PR run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant