Reject shadowed global flags on proper subcommands#2255
Draft
afrancke wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Andy Francke <andy@francke.com>
afrancke
force-pushed
the
afrancke/reject-shadowed-global-subcommand-flags
branch
from
55b6d40 to
491c07f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2254.
Summary
Reject a flag parsed globally when a proper subcommand declares the same flag and no command-local value was supplied. This prevents a command from succeeding with a default value while silently ignoring the user's earlier global value.
The guard applies to all six commands migrated by #1333/#1391:
decrypt,encrypt,rotate,edit,set, andunset. It leaves true global-only flags alone and allows the unambiguous command-local form.Tests
go test ./cmd/sopscargo fmt --checkinfunctional-testscargo test proper_subcommands_reject_shadowed_global_flagscargo test decrypt_output_type_after_subcommand_emits_jsonThe new black-box coverage verifies every observed decrypt collision (
--output-type,--input-type,--output,--extract, and--ignore-mac), all six migrated proper subcommands, zero stdout on rejection, and valid JSON from the command-local placement.