Use net/url.Parse in extractHost to prevent host confusion#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom
extractHost()function indefaults.gomanually parsed URLs by splitting on://,@, and path separators. This hand-rolled parser could be confused by URLs with encoded characters or unusual userinfo components, causingIsDefaultRegistryandIsPrivateRegistryto misclassify hostile URLs as the official registry.Replaced with
net/url.Parse()followed byHostname(), which handles all the edge cases (userinfo, percent-encoding, IPv6 brackets, etc.) correctly.Added
TestExtractHostRejectsUserinfoto verify that userinfo in URLs does not confuse host extraction.