Skip to content

book deploy: retry the flaky redirect check, and upload the Playwright report on failure #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dscho merged 2 commits into from
Jun 25, 2026
+22 −5
Merged

book deploy: retry the flaky redirect check, and upload the Playwright report on failure #2177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f706470
ci(book): upload the Playwright report when the deploy job fails
dscho Jun 25, 2026
830490c
tests: retry the book redirect to dodge "chrome-error://chromewebdata/"
dscho Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/deploy-to-github-pages/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,9 @@ runs:
PLAYWRIGHT_TEST_URL: ${{ env.base_url }}
# avoid test failures when HTTPS is enforced half-way through
PLAYWRIGHT_EXTERNAL_HTTPS: ${{ inputs.external-https }}
run: npx playwright test --project=chrome
run: |
echo "result=$PLAYWRIGHT_TEST_URL" >>$GITHUB_OUTPUT &&
npx playwright test --project=chrome
- uses: actions/upload-artifact@v7
if: always() && steps.playwright.outputs.result != ''
with:
Expand Down
23 changes: 19 additions & 4 deletions tests/git-scm.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,23 @@ test.afterEach(async ({ page }, testInfo) => {

if (process.platform === 'win32') test.setTimeout(60_000) // give it some time

// Navigating to a page that immediately redirects elsewhere via
// `<meta http-equiv="refresh" content="0; url=...">` occasionally races with
// Chrome's navigation handling: the in-flight load is aborted and the page is
// left stranded on the internal error page `chrome-error://chromewebdata/`.
// As that is a committed navigation, merely polling for the target URL cannot
// recover from it, the navigation has to be re-triggered. This is a known,
// transient Playwright/Chromium issue (see e.g.
// https://github.com/microsoft/playwright/issues/19161), so retry the whole
// navigate-and-assert dance until the expected URL is reached.
async function gotoAndExpectRedirect(page, gotoURL, expectedURL) {
await expect(async () => {
await page.goto(gotoURL)
await expect(page).toHaveURL(expectedURL)
// Retry every second for up to 15 seconds in total
}).toPass({ intervals: [1_000], timeout: 15_000 });
}

test('generator is Hugo', async ({page}) => {
await page.goto(url)
await expect(page.locator('meta[name="generator"]')).toHaveAttribute('content', /^Hugo /)
Expand Down Expand Up @@ -189,11 +206,9 @@ test('anchor links in manual pages', async ({ page }) => {
})

test('book', async ({ page }) => {
await page.goto(`${url}book/`)
await expect(page).toHaveURL(`${url}book/en/v2`)
await gotoAndExpectRedirect(page, `${url}book/`, `${url}book/en/v2`)

await page.goto(`${url}book`)
await expect(page).toHaveURL(`${url}book/en/v2`)
await gotoAndExpectRedirect(page, `${url}book`, `${url}book/en/v2`)

// the repository URL is correct
await expect(page.getByRole('link', { name: 'hosted on GitHub' }))
Expand Down
Loading