Add preview deployments for PR's - #2755
Open
rezrah wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pull-request website previews while retaining builds for forks.
Changes:
- Adds a PR-triggered GitHub Pages preview workflow.
- Replaces the previous website build workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/deploy-website-preview.yml |
Builds and conditionally deploys PR previews. |
.github/workflows/build-website.yml |
Removes the superseded build-only workflow. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| id: deployment | ||
| uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5 | ||
| with: | ||
| preview: true |
Collaborator
Author
There was a problem hiding this comment.
It's fine, i've enabled the feature on the repo and deployment will not occur on forks.
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
.github/workflows/deploy-website-preview.yml:86
actions/deploy-pages@v4.0.5documents thispreviewinput as an alpha feature that is not publicly available. Unless this repository is explicitly enrolled in that private alpha, the deployment API will reject these runs, so deleting the existing build workflow leaves affected PRs without a successful replacement. Use a supported preview-hosting mechanism (or retain build-only CI until Pages previews are enabled).
preview: true
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
buildworkflow for PRs. Build CI is consolidated into the deploy workflow.Type of Contribution
General infra upgrade
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.