-
Notifications
You must be signed in to change notification settings - Fork 76
Add lifetime package #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
knewbury01
wants to merge
13
commits into
github:main
Choose a base branch
from
knewbury01:knewbury01/Lifetime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add lifetime package #1024
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c29ca80
Add lifetime rule RULE-11-6-2
knewbury01 6956667
Merge branch 'main' into knewbury01/Lifetime
knewbury01 9651122
Add improvements to readofuninitializedmemory and testcase
knewbury01 d0f2ede
Remove unnecessary import in readofuninitializedmemory
knewbury01 1c610ee
Add shared query for RULE-6-8-3
knewbury01 a903b40
Merge branch 'main' into knewbury01/Lifetime
knewbury01 1704bb8
Format query
knewbury01 dd5ebd3
Merge branch 'knewbury01/Lifetime' of https://github.com/knewbury01/c…
knewbury01 ac21481
Add another missing query format
knewbury01 b2e8f3a
Revert shared rule to class not module since it shares with old style
knewbury01 1649c21
Improve tests to be more clear on whether certain cases are supported…
knewbury01 db1a631
Address review comments
knewbury01 3baadfb
Fix testcase formatting
knewbury01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -259,6 +259,7 @@ | |
| "Language1", | ||
| "Language2", | ||
| "Language3", | ||
| "Lifetime", | ||
| "Linkage1", | ||
| "Linkage2", | ||
| "Literals", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| - `A8-5-0`, `EXP53-CPP`, `EXP33-C`, `RULE-9-1` - `MemoryNotInitializedBeforeItIsRead.ql`, `DoNotReadUninitializedMemory.ql`, `DoNotReadUninitializedMemory.ql`, `ObjectWithAutoStorageDurationReadBeforeInit.ql`: | ||
| - The queries listed now find uses of the operator 'new' where there is no value initialization provided. The queries listed now also uses an out of the box library to consider initialization within another function as valid initialization (`InitializationFunctions.qll`). We do not yet track finely track the initialization/use of `p` vs `*p`. |
44 changes: 44 additions & 0 deletions
44
cpp/common/src/codingstandards/cpp/exclusions/cpp/Lifetime.qll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| //** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY. **/ | ||
| import cpp | ||
| import RuleMetadata | ||
| import codingstandards.cpp.exclusions.RuleMetadata | ||
|
|
||
| newtype LifetimeQuery = | ||
| TValueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery() or | ||
| TAutomaticStorageAssignedToObjectGreaterLifetimeQuery() | ||
|
|
||
| predicate isLifetimeQueryMetadata(Query query, string queryId, string ruleId, string category) { | ||
| query = | ||
| // `Query` instance for the `valueOfAnObjectMustNotBeReadBeforeItHasBeenSet` query | ||
| LifetimePackage::valueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery() and | ||
| queryId = | ||
| // `@id` for the `valueOfAnObjectMustNotBeReadBeforeItHasBeenSet` query | ||
| "cpp/misra/value-of-an-object-must-not-be-read-before-it-has-been-set" and | ||
| ruleId = "RULE-11-6-2" and | ||
| category = "mandatory" | ||
| or | ||
| query = | ||
| // `Query` instance for the `automaticStorageAssignedToObjectGreaterLifetime` query | ||
| LifetimePackage::automaticStorageAssignedToObjectGreaterLifetimeQuery() and | ||
| queryId = | ||
| // `@id` for the `automaticStorageAssignedToObjectGreaterLifetime` query | ||
| "cpp/misra/automatic-storage-assigned-to-object-greater-lifetime" and | ||
| ruleId = "RULE-6-8-3" and | ||
| category = "required" | ||
| } | ||
|
|
||
| module LifetimePackage { | ||
| Query valueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery() { | ||
| //autogenerate `Query` type | ||
| result = | ||
| // `Query` type for `valueOfAnObjectMustNotBeReadBeforeItHasBeenSet` query | ||
| TQueryCPP(TLifetimePackageQuery(TValueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery())) | ||
| } | ||
|
|
||
| Query automaticStorageAssignedToObjectGreaterLifetimeQuery() { | ||
| //autogenerate `Query` type | ||
| result = | ||
| // `Query` type for `automaticStorageAssignedToObjectGreaterLifetime` query | ||
| TQueryCPP(TLifetimePackageQuery(TAutomaticStorageAssignedToObjectGreaterLifetimeQuery())) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.