Propagate GH_AW_INFO_ENGINE_ID into setup steps so setup OTel spans emit gh-aw.engine.id#32298
Draft
Copilot wants to merge 2 commits into
Draft
Propagate GH_AW_INFO_ENGINE_ID into setup steps so setup OTel spans emit gh-aw.engine.id#32298Copilot wants to merge 2 commits into
GH_AW_INFO_ENGINE_ID into setup steps so setup OTel spans emit gh-aw.engine.id#32298Copilot wants to merge 2 commits into
Conversation
8 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve OTel instrumentation to propagate gh-aw.engine.id to setup spans
Propagate May 15, 2026
GH_AW_INFO_ENGINE_ID into setup steps so setup OTel spans emit gh-aw.engine.id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
gh-aw.<job>.setupspans were missinggh-aw.engine.idbecause setup runs beforeaw_info.jsonexists and setup steps did not receiveGH_AW_INFO_ENGINE_ID. This blocked engine-segmented setup observability (e.g., p95 setup latency and pre-agent failure rate by engine).What was the bug?
sendJobSetupSpan) already supportsGH_AW_INFO_ENGINE_ID, but compiled setup steps did not inject that env var.How did you fix it?
Setup-step engine env propagation
getEngineIDForSetup(data *WorkflowData)to resolve engine ID from:EngineConfig.ID(preferred)AIfield (fallback)GH_AW_INFO_ENGINE_IDinto generated Setup Scripts step env in:uses: ./actions/setup)bash .../setup.sh)Compiler/output alignment
Focused coverage
Testing
GH_AW_INFO_ENGINE_IDis emitted in setup steps (action + script modes), and refreshed corresponding wasm golden outputs.