Consolidate CLI not-found error classification by Copilot · Pull Request #52621 · github/gh-aw

Copilot · 2026-08-14T03:54:49Z

Several CLI paths duplicated 404/not found detection instead of using errorutil. One case was case-sensitive and missed GitHub’s title-case Not Found output.

Shared classification
- Add errorutil.IsNotFoundOutput(string) for raw CLI output.
- Reuse the existing case-insensitive matching logic.
CLI consolidation
- Replace five inline predicates with shared classifiers.
- Remove obsolete helper functions and temporary errors.New wrappers.
- Preserve specialized repository-resolution handling.
Regression coverage
- Cover raw output variants, including title-case Not Found.
- Verify missing remote experiments return the specific not-found error.

Fixes [refactor] errorutil duplicated in 5 pkg/cli sites (one with a case-sensitivity bug); fileutil is clean #52611

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.41 AIC · ⌖ 6.61 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Consolidates CLI not-found detection through errorutil, fixing title-case Not Found handling from issue #52611.

Changes:

Adds a case-insensitive raw-output classifier.
Replaces duplicated CLI predicates and temporary error wrappers.
Adds regression coverage for classifier variants and remote experiments.

Show a summary per file

File	Description
`pkg/errorutil/errors.go`	Adds shared raw-output classification.
`pkg/errorutil/errors_test.go`	Tests output variants.
`pkg/cli/workflow_run_metadata.go`	Removes temporary error wrapping.
`pkg/cli/setup_repository.go`	Centralizes repository not-found detection.
`pkg/cli/logs_download.go`	Classifies raw CLI output directly.
`pkg/cli/experiments_command.go`	Fixes case-insensitive experiment detection.
`pkg/cli/experiments_command_test.go`	Adds remote experiment regression coverage.
`pkg/cli/evals_branch.go`	Reuses the shared classifier.
`pkg/cli/checks_command.go`	Replaces inline matching.
`pkg/cli/branch_file_reader.go`	Removes the duplicate output helper.
`pkg/cli/add_package_manifest.go`	Removes the duplicate error helper.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 11/11 changed files
Comments generated: 2
Review effort level: Balanced

+func TestFetchRemoteExperimentDetailsClassifiesTitleCaseNotFound(t *testing.T) {
+	fakeBinDir := t.TempDir()
+	fakeGH := filepath.Join(fakeBinDir, "gh")
+	require.NoError(t, os.WriteFile(fakeGH, []byte("#!/bin/sh\necho 'HTTP 404: Not Found' >&2\nexit 1\n"), 0o755))


+// IsNotFoundOutput reports whether output represents an HTTP 404 / "not found" response.
+// The check is case-insensitive and matches both the numeric literal "404" and
+// the phrase "not found".
+func IsNotFoundOutput(output string) bool {


github-actions · 2026-08-14T06:48:59Z

Triage: refactor / risk: low

Score: 37/100 (impact+urgency+quality) · Priority: medium · Action: batch_review · Batch: lint-cleanup-cluster

Consolidates CLI not-found error classification into errorutil, fixes case-sensitivity gap. CI green.

_{Automated PR triage — see full report issue for details.}

Generated by 🔧 PR Triage Agent · auto · 48.2 AIC · ⌖ 2.57 AIC · ⊞ 7.8K · ◷

github-actions · 2026-08-14T12:35:37Z

PR Triage\n\n- Category: refactor\n- Risk: low\n- Priority: medium\n- Score: 48/100 (impact 25 + urgency 15 + quality 8)\n- Recommended action: `batch_review`\n- Batch: `refactor-consolidation-cluster`\n

Generated by 🔧 PR Triage Agent · auto · 62.8 AIC · ⌖ 2.76 AIC · ⊞ 7.8K · ◷

github-actions · 2026-08-14T18:37:46Z

PR Triage

Category: refactor
Risk: medium
Priority: medium (score: 41/100)
Score breakdown: impact 15/50, urgency 20/30, quality 6/20
Recommended action: batch_review
Batch: refactor-cleanup-cluster
Note: CI failing (Unit tests A-C)

Automated triage by PR Triage Agent.

Generated by 🔧 PR Triage Agent · auto · 64.3 AIC · ⌖ 2.94 AIC · ⊞ 7.8K · ◷

gh-aw-bot · 2026-08-14T19:35:55Z

@copilot Please run the pr-finisher skill after addressing the current failure and summarize the maintainer-ready state in one comment.

Failed checks:

Unit tests (A-C): https://github.com/github/gh-aw/actions/runs/31769091169/job/94687662652

Run: https://github.com/github/gh-aw/actions/runs/31833406387

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.41 AIC · ⌖ 6.61 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

github-actions · 2026-08-15T00:34:49Z

PR Triage

Category: refactor | Risk: medium | Score: 33/100

Score breakdown

Impact: 15/50
Urgency: 8/30
Quality: 10/20

Recommended action: `batch_review`

Batch: refactor-cleanup-cluster

12 files touched, only comment-level review so far, no CI data.

Generated by 🔧 PR Triage Agent · auto · 68.2 AIC · ⌖ 10.7 AIC · ⊞ 7.8K · ◷

Initial plan

1ef4dc4

Copilot AI assigned Copilot and pelikhan Aug 14, 2026

Copilot AI linked an issue Aug 14, 2026 that may be closed by this pull request

[refactor] errorutil duplicated in 5 pkg/cli sites (one with a case-sensitivity bug); fileutil is clean #52611

Closed

Copilot started work on behalf of pelikhan August 14, 2026 03:55 View session

Copilot AI and others added 3 commits August 14, 2026 04:06

Consolidate not-found error classification

b17fdb0

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Normalize raw repository error output

d1a0015

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Reuse repository error output string

4433868

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor pkg/errorutil duplicates in pkg/cli~~ Consolidate CLI not-found error classification Aug 14, 2026

Copilot finished work on behalf of pelikhan August 14, 2026 04:13

Copilot AI requested a review from pelikhan August 14, 2026 04:13

pelikhan marked this pull request as ready for review August 14, 2026 05:54

Copilot AI balanced review requested due to automatic review settings August 14, 2026 05:54

Copilot started reviewing on behalf of pelikhan August 14, 2026 05:55 View session

Copilot AI reviewed Aug 14, 2026

View reviewed changes

github-actions Bot added pr-action:batch_review pr-agent:copilot pr-batch:lint-cleanup-cluster pr-priority:medium pr-risk:low pr-type:refactor labels Aug 14, 2026

github-actions Bot mentioned this pull request Aug 14, 2026

[pr-sous-chef] PR Sous Chef run report - 2026-08-14T00:39:51Z #52601

Closed

github-actions Bot added the pr-batch:refactor-consolidation-cluster label Aug 14, 2026

github-actions Bot mentioned this pull request Aug 14, 2026

[PR Triage Report] PR Triage Report — 2026-08-14 (Run 31800275586) #52717

Closed

github-actions Bot added pr-batch:refactor-cleanup-cluster pr-risk:medium labels Aug 14, 2026

github-actions Bot mentioned this pull request Aug 14, 2026

[PR Triage Report] PR Triage Report — 2026-08-14 (24 open PRs) #52773

Closed

Merge branch 'main' into copilot/refactor-errorutil-duplicates

cb36b8f

Copilot started work on behalf of gh-aw-bot August 14, 2026 19:36 View session

Fix flaky actionpins tests: remove t.Parallel from CaptureStderr tests

b579e4a

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI requested a review from gh-aw-bot August 14, 2026 19:52

github-actions Bot added the pr-priority:low label Aug 15, 2026

github-actions Bot mentioned this pull request Aug 15, 2026

[PR Triage Report] PR Triage Report — 2026-08-15 (Run 31853447878) #52806

Closed

pelikhan merged commit ab48eba into main Aug 15, 2026
27 checks passed

pelikhan deleted the copilot/refactor-errorutil-duplicates branch August 15, 2026 04:54

Navigation Menu

Uh oh!

Consolidate CLI not-found error classification - #52621

Consolidate CLI not-found error classification#52621
pelikhan merged 6 commits into
mainfrom
copilot/refactor-errorutil-duplicates

Copilot AI commented Aug 14, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

gh-aw-bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Aug 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Aug 14, 2026

Triage: refactor / risk: low

Uh oh!

github-actions Bot commented Aug 14, 2026

PR Triage\n\n- Category: refactor\n- Risk: low\n- Priority: medium\n- Score: 48/100 (impact 25 + urgency 15 + quality 8)\n- Recommended action: batch_review\n- Batch: refactor-consolidation-cluster\n

Uh oh!

github-actions Bot commented Aug 14, 2026

PR Triage

Uh oh!

gh-aw-bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 15, 2026

PR Triage

Score breakdown

Recommended action: batch_review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 14, 2026 •

edited by github-actions Bot

Loading

PR Triage\n\n- Category: refactor\n- Risk: low\n- Priority: medium\n- Score: 48/100 (impact 25 + urgency 15 + quality 8)\n- Recommended action: `batch_review`\n- Batch: `refactor-consolidation-cluster`\n

Recommended action: `batch_review`