Embed AggregatedSummaryBase in MCPFailureSummary

[Copilot]

MCPFailureSummary duplicated aggregation fields already defined in AggregatedSummaryBase, creating drift risk when shared summary fields change. This refactor aligns it with the existing MissingToolSummary and MissingDataSummary pattern.

• Model refactor

  • Embed AggregatedSummaryBase in MCPFailureSummary
  • Remove duplicated Count, Workflows, WorkflowsDisplay, and RunIDs fields
  • Update the base comment to reflect all embedding summary types

• Aggregation update

  • Initialize MCP failure summaries through the embedded base while preserving promoted field access

• Coverage

  • Update MCP failure summary fixtures for embedded initialization
  • Add JSON coverage confirming embedded fields remain flattened at the top level

type MCPFailureSummary struct {
	ServerName string `json:"server_name" console:"header:Server"`
	AggregatedSummaryBase
}

• Fixes [deep-report] MCPFailureSummary hand-copies fields instead of embedding AggregatedSummaryBase #52517

---

Run: https://github.com/github/gh-aw/actions/runs/31795158705> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.47 AIC · ⌖ 7.2 AIC · ⊞ 8.5K · ◷

_{Comment /souschef to run again}

[github-actions]

Great work on this refactor! 🚀 You have successfully eliminated the duplicated aggregation fields in MCPFailureSummary by embedding AggregatedSummaryBase, aligning it with the existing patterns used in MissingToolSummary and MissingDataSummary.

What stands out:

• ✅ Focused scope — single, cohesive refactor
• ✅ Test coverage — fixtures updated and JSON flattening behavior verified
• ✅ Clear explanation — detailed PR body with code examples
• ✅ Drift risk eliminated — shared summary fields now have a single source of truth

This is exactly the kind of mechanical, low-risk refactoring that keeps the codebase maintainable. The PR is ready for review and merge.

Generated by ✅ Contribution Check · auto · 53.9 AIC · ⌖ 3.24 AIC · ⊞ 8.8K · ◷

[Copilot]

Pull request overview

Refactors MCP failure summaries to embed the shared aggregation model and reduce field duplication.

Changes:

• Embeds AggregatedSummaryBase in MCPFailureSummary.
• Updates aggregation and test fixtures for embedded initialization.
• Adds flattened JSON serialization coverage.

Show a summary per file

File	Description
pkg/cli/logs_models.go	Refactors the summary model.
pkg/cli/logs_report_mcp.go	Initializes the embedded base.
pkg/cli/logs_report_test.go	Updates report fixtures.
pkg/cli/logs_display_fields_test.go	Updates console checks and adds JSON coverage.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 4/4 changed files
• Comments generated: 2
• Review effort level: Balanced

[gh-aw-bot]

@copilot
Quick triage for maintainer-ready follow-up:

Unresolved review threads (newest first):

• copilot-pull-request-reviewer: Embed AggregatedSummaryBase in MCPFailureSummary #52670 (comment) — The source-verified export appendix is now stale: pkg/cli/README.md:625-627 still documents AggregatedSummaryBase as only a subset of th
• copilot-pull-request-reviewer: Embed AggregatedSummaryBase in MCPFailureSummary #52670 (comment) — Embedding the entire base is not behavior-preserving. AggregatedSummaryBase also exposes first_reason in JSON and First Reason in cons

Please refresh the branch if needed, address the unresolved review feedback, rerun validation, and use the pr-finisher skill before handing back.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.47 AIC · ⌖ 7.2 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot
Quick triage for maintainer-ready follow-up:
...

Addressed the unresolved feedback in fb3f2e3: MCP output again uses its original JSON and console schema, and the exported-model appendix now reflects the embedding. Local scoped validation passed.

[github-actions]

PR Triage\n\n- Category: refactor\n- Risk: low\n- Priority: medium\n- Score: 50/100 (impact 25 + urgency 15 + quality 10)\n- Recommended action: batch_review\n- Batch: refactor-consolidation-cluster\n

Generated by 🔧 PR Triage Agent · auto · 62.8 AIC · ⌖ 2.76 AIC · ⊞ 7.8K · ◷

[github-actions]

PR Triage

• Category: refactor
• Risk: medium
• Priority: medium (score: 42/100)
• Score breakdown: impact 18/50, urgency 10/30, quality 14/20
• Recommended action: batch_review
• Batch: refactor-cleanup-cluster

Automated triage by PR Triage Agent.

Generated by 🔧 PR Triage Agent · auto · 64.3 AIC · ⌖ 2.94 AIC · ⊞ 7.8K · ◷