Draft
Formalize §4.6 effective-integrity model with executable compliance tests#52751
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for effective integrity computation algorithm
Formalize §4.6 effective-integrity model with executable compliance tests
Aug 14, 2026
Contributor
PR Triage
Automated triage by PR Triage Agent.
|
Contributor
PR TriageCategory: Score breakdown
Recommended action:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specs/github-mcp-access-control-compliance/README.mddocumented guard-level formal tests (P1–P6), but the §4.6 effective-integrity computation (blocked-users/trusted-users/approval-labels+min-integrity) had no executable coverage. This PR adds a dedicated formal suite to close that gap and records the new coverage in the compliance README.Effective integrity formal model (new test suite)
pkg/workflow/github_mcp_effective_integrity_formal_test.gowith self-contained model types and evaluator helpers.blocked-usersshort-circuits toblocked(cannot be overridden)trusted-usersandapproval-labelselevate viamax(base, approved)min-integritymin-integrityallows non-blocked contentmin-integritydenies fail-safenonefor decisioningSpec fixture documentation alignment
specs/github-mcp-access-control-compliance/README.mdto include an Effective Integrity Model Coverage (§4.6) table and reference the new formal suite in usage/generated-suite sections.