Skip to content

Enable per-PR continuity memory writes in PR Code Quality Reviewer - #52759

Merged
pelikhan merged 7 commits into
mainfrom
copilot/deep-report-fix-cache-memory-issue
Aug 15, 2026
Merged

Enable per-PR continuity memory writes in PR Code Quality Reviewer#52759
pelikhan merged 7 commits into
mainfrom
copilot/deep-report-fix-cache-memory-issue

Conversation

Copilot AI commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The workflow prompt instructed reviewers to read a per-PR continuity file, but never instructed writing it, so continuity context was effectively unavailable across repeated reviews. This change closes that gap by defining a post-review memory write contract at the same cache path already used for reads.

  • Problem alignment

    • The workflow already attempted to read:
      • /tmp/gh-aw/cache-memory/pr-${{ github.event.issue.number || github.event.pull_request.number }}.json
    • No corresponding write instruction existed in the prompt body.
  • Workflow prompt update

    • Added Step 6: Update PR Continuity Memory to / .github/workflows/pr-code-quality-reviewer.md.
    • New step instructs writing a compact per-PR JSON snapshot after review submission.
    • Snapshot fields are constrained to continuity-relevant data:
      • reviewed_at
      • review_event (COMMENT or REQUEST_CHANGES)
      • top_themes
      • files_reviewed
      • comment_count
  • Generated workflow sync

    • Updated the compiled lockfile (.github/workflows/pr-code-quality-reviewer.lock.yml) to match the markdown workflow source.
### Step 6: Update PR Continuity Memory

After submitting the review, write a compact JSON snapshot to
`/tmp/gh-aw/cache-memory/pr-${{ github.event.issue.number || github.event.pull_request.number }}.json`
so repeat reviews of this PR can load continuity context in Step 1.

Run: https://github.com/github/gh-aw/actions/runs/31871584565> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.5 AIC · ⌖ 5.77 AIC · ⊞ 8.7K ·

Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.4 AIC · ⌖ 6.65 AIC · ⊞ 6.3K ·
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.4 AIC · ⌖ 5.87 AIC · ⊞ 6.3K ·
Comment /souschef to run again


Run: https://github.com/github/gh-aw/actions/runs/31883373617> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 16.4 AIC · ⌖ 5.78 AIC · ⊞ 6.3K ·

Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.6 AIC · ⌖ 7.98 AIC · ⊞ 8.7K ·
Comment /souschef to run again


branch refresh requested from run https://github.com/github/gh-aw/actions/runs/31886878354> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.7 AIC · ⌖ 5.9 AIC · ⊞ 8.7K ·

Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix cache-memory continuity file writing for PR reviews Enable per-PR continuity memory writes in PR Code Quality Reviewer Aug 14, 2026
Copilot AI requested a review from pelikhan August 14, 2026 16:42
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

  • Category: feature
  • Risk: low
  • Priority: low (score: 30/100)
  • Score breakdown: impact 10/50, urgency 5/30, quality 15/20
  • Recommended action: defer

Automated triage by PR Triage Agent.

Generated by 🔧 PR Triage Agent · auto · 64.3 AIC · ⌖ 2.94 AIC · ⊞ 7.8K ·

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

Category: feature  |  Risk: low  |  Score: 29/100

Score breakdown

  • Impact: 15/50
  • Urgency: 8/30
  • Quality: 6/20

Recommended action: defer

Draft, meta-workflow enhancement, no reviews yet.

Generated by 🔧 PR Triage Agent · auto · 68.2 AIC · ⌖ 10.7 AIC · ⊞ 7.8K ·

@github-actions

Copy link
Copy Markdown
Contributor

Hey @github/gh-aw-team 👋 — thanks for addressing the continuity gap in PR Code Quality Reviewer! This feature closes an important feedback loop by enabling the workflow to read and write per-PR memory snapshots.

Here's what looks good:

A few things to strengthen this:

  • Add integration test — workflow changes benefit from validation that the Step 6 JSON write actually executes and persists the snapshot to the cache-memory path as intended. Even a smoke test confirming the file is created would be valuable.
  • Document snapshot schema — the PR mentions constrained snapshot fields (reviewed_at, review_event, top_themes, files_reviewed, comment_count), but there's no schema definition in the markdown or lock file. Consider adding a brief YAML example comment showing the expected structure.

If you'd like a hand, you can assign this prompt to your coding agent:

Add a test or smoke test to validate that Step 6 of the PR Code Quality Reviewer workflow correctly writes a JSON snapshot to /tmp/gh-aw/cache-memory/pr-{number}.json after a review is submitted. The snapshot should include the fields: reviewed_at, review_event, top_themes, files_reviewed, and comment_count. Document the expected schema in a comment in pr-code-quality-reviewer.md.

Generated by ✅ Contribution Check · auto · 53.6 AIC · ⌖ 3.28 AIC · ⊞ 8.8K ·

@pelikhan
pelikhan marked this pull request as ready for review August 15, 2026 04:57
Copilot AI balanced review requested due to automatic review settings August 15, 2026 04:57
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds continuity persistence so repeated PR reviews can reuse prior review context.

Changes:

  • Adds a compact per-PR JSON memory-write contract.
  • Updates the generated workflow metadata hash.
Show a summary per file
File Description
.github/workflows/pr-code-quality-reviewer.md Adds continuity snapshot instructions.
.github/workflows/pr-code-quality-reviewer.lock.yml Synchronizes generated workflow metadata.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address any remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR ba...

Completed another triage pass on 5981ed0: no unresolved review threads, branch remains current with main, and local validation passed (make fmt, make lint, make test-unit, make test, make recompile). I also checked workflow runs for this branch and pulled failed-job logs for run 31874029539; no failed jobs were reported.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address any remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

  • No unresolved review threads were surfaced from available context; please verify current maintainer expectations before handoff.

Failed checks from the compact candidate set:

  • None listed.

Branch update was requested automatically for this run when GitHub allows it.
Run context: https://github.com/github/gh-aw/actions/runs/31875928309

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.4 AIC · ⌖ 6.65 AIC · ⊞ 6.3K ·
Comment /souschef to run again

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address any remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR ba...

Completed triage on 5981ed0.

  • Branch is current with main (base SHA 19e875b matches current main head).
  • No unresolved PR review threads are present for this PR.
  • Checked recent workflow runs for this branch and pulled failed-job logs for the latest candidate non-success run (31868487425); no failed jobs were reported.
  • No additional code changes were required in this pass.

Hand-off: CI on this PR head remains observational/stale until a maintainer re-triggers workflows with a non-agent push or manual dispatch.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address any remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

  • No unresolved review threads were surfaced from available context; please verify current maintainer expectations before handoff.

Failed checks from the compact candidate set:

  • None listed.

Branch update was requested automatically for this run when GitHub allows it.
Run context: https://github.com/github/gh-aw/actions/runs/31880300352

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.4 AIC · ⌖ 5.87 AIC · ⊞ 6.3K ·
Comment /souschef to run again

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address any remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR ba...

Completed another triage pass on 5981ed0.

  • Branch head remains aligned with main (base SHA 19e875b).
  • No unresolved PR review threads are present.
  • Reviewed recent branch workflow runs and fetched failed-job logs for the latest candidate non-success run (31868487425); no failed jobs were reported.
  • No additional code changes were required in this pass.

Hand-off: CI for this PR head remains observational/stale until a maintainer re-triggers workflows with a non-agent push or manual dispatch.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot quick triage for this PR:

  • please refresh the branch with the latest base changes if GitHub's branch update is available
  • review the current PR feedback and checks status
  • then run the pr-finisher skill to drive this PR toward maintainer-ready state

Run: https://github.com/github/gh-aw/actions/runs/31883373617

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 16.4 AIC · ⌖ 5.78 AIC · ⊞ 6.3K ·
Comment /souschef to run again

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot quick triage for this PR:

  • please refresh the branch with the latest base changes if GitHub's branch update is available...

Completed triage on 5981ed0.

  • Branch is already current with base (main head/base SHA 19e875b), so no refresh action was needed.
  • Reviewed current PR feedback state: no unresolved review threads are present.
  • Checked recent workflow runs for this branch and fetched failed-job logs for the latest candidate non-success run (31868487425); no failed jobs were reported.
  • No additional code changes were required in this pass.

Hand-off: CI for this PR head remains observational/stale until a maintainer re-triggers workflows with a non-agent push or manual dispatch.

@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

  • Category: feature
  • Risk: low
  • Priority: low
  • Score: 36/100
  • Recommended action: defer

Adds a missing memory-write step to a review workflow prompt. Low-risk, low-value; CI passing (5/5).

Automated triage — see [PR Triage Report] for full context.

Generated by 🔧 PR Triage Agent · auto · 62.5 AIC · ⌖ 2.53 AIC · ⊞ 8.1K ·

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address the remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

  • No unresolved review threads were available from the current compact context; please verify the latest reviewer expectations and prepare this PR for maintainer handoff.

Failed checks from the compact candidate set:

  • None listed.

Branch update was requested automatically for this run when GitHub allows it.
Run context: https://github.com/github/gh-aw/actions/runs/31885005799

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.6 AIC · ⌖ 7.98 AIC · ⊞ 8.7K ·
Comment /souschef to run again

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, address the remaining maintainer-facing follow-up, and run the pr-finisher skill before handing this PR ba...

Completed triage on 9c220b7.

  • Branch is current with main (origin/main = 6b3d3de, and main is an ancestor of this PR head).
  • Latest review state verified: no unresolved review threads.
  • Local validation passed in this run: make fmt, make lint, make test-unit, make test, make recompile.
  • Reviewed recent workflow runs and fetched failed-job logs for the latest candidate non-success run (31885316304); no failed jobs were reported.
  • No additional code changes were required.

Hand-off: CI on this PR head remains stale/observational after agent activity and must be re-triggered by a maintainer (manual dispatch, close/reopen, or a maintainer push) before merge.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot use comment-memory

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot use comment-memory

Implemented in 63f6ff1.

Switched this workflow from cache-memory to comment-memory for PR continuity:

  • tools.comment-memory is now enabled with memory-id: pr-code-quality-reviewer
  • Step 1 now reads /tmp/gh-aw/comment-memory/pr-code-quality-reviewer.md
  • Step 6 now updates the same comment-memory file
  • Recompiled .github/workflows/pr-code-quality-reviewer.lock.yml to keep it in sync

@pelikhan
pelikhan merged commit 13fddbc into main Aug 15, 2026
@pelikhan
pelikhan deleted the copilot/deep-report-fix-cache-memory-issue branch August 15, 2026 13:22
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items:

  • summarize the user-visible impact of moving PR continuity from cache-memory to comment-memory, especially any migration or retention implications maintainers should know

Failed checks from the compact candidate set:

  • None listed.

Branch update was requested automatically for this run when GitHub allows it.
Run context: https://github.com/github/gh-aw/actions/runs/31886878354

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.7 AIC · ⌖ 5.9 AIC · ⊞ 8.7K ·
Comment /souschef to run again

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.86.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] PR Code Quality Reviewer reads a per-PR cache-memory continuity file that is never written

4 participants