disable potentially vulnerable workflow#3664
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the GitHub Actions workflow that deploys a Jekyll site to a GitHub Pages preview environment, likely to mitigate risk associated with the current PR-targeted deployment approach.
Changes:
- Comments out the entire
.github/workflows/jekyll-preview.ymlworkflow so it no longer defines triggers/jobs. - Effectively removes the Pages preview build/deploy pipeline from CI.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/jekyll-preview.yml | Entire workflow content is commented out to prevent Pages preview deployments from running. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
Comment on lines
+1
to
+65
| # # This workflow uses actions that are not certified by GitHub. | ||
| # # They are provided by a third-party and are governed by | ||
| # # separate terms of service, privacy policy, and support | ||
| # # documentation. | ||
| # | ||
| # # Sample workflow for building and deploying a Jekyll site to GitHub Pages | ||
| # name: Deploy Jekyll site to Pages preview environment | ||
| # on: | ||
| # # Runs on pull requests targeting the default branch | ||
| # pull_request_target: | ||
| # branches: ["main"] | ||
| # # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages | ||
| # permissions: | ||
| # contents: read | ||
| # pages: write | ||
| # id-token: write | ||
| # # Allow only one concurrent deployment per PR, skipping runs queued between the run in-progress and latest queued. | ||
| # # However, do NOT cancel in-progress runs as we want to allow these production deployments to complete. | ||
| # concurrency: | ||
| # group: "pages-preview @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}" | ||
| # cancel-in-progress: false | ||
| # jobs: | ||
| # # Build job | ||
| # build: | ||
| # environment: | ||
| # name: "Pages Preview" | ||
| # # Limit permissions of the GITHUB_TOKEN for untrusted code | ||
| # permissions: | ||
| # contents: read | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - name: Checkout | ||
| # uses: actions/checkout@v6.0.2 | ||
| # with: | ||
| # # For PRs make sure to checkout the PR branch | ||
| # ref: ${{ github.event.pull_request.head.sha }} | ||
| # repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
| # - name: Setup Pages | ||
| # uses: actions/configure-pages@v6.0.0 | ||
| # - name: Build with Jekyll | ||
| # uses: actions/jekyll-build-pages@44a6e6beabd48582f863aeeb6cb2151cc1716697 # v1 | ||
| # with: | ||
| # source: ./ | ||
| # destination: ./_site | ||
| # - name: Upload artifact | ||
| # # Automatically uploads an artifact from the './_site' directory by default | ||
| # uses: actions/upload-pages-artifact@v5.0.0 | ||
| # # Deployment job | ||
| # deploy: | ||
| # environment: | ||
| # name: "Pages Preview" | ||
| # url: ${{ steps.deployment.outputs.page_url }} | ||
| # # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages | ||
| # permissions: | ||
| # contents: read | ||
| # pages: write | ||
| # id-token: write | ||
| # runs-on: ubuntu-latest | ||
| # needs: build | ||
| # steps: | ||
| # - name: Deploy to GitHub Pages | ||
| # id: deployment | ||
| # uses: actions/deploy-pages@v5.0.0 | ||
| # with: | ||
| # preview: "true" |
Comment on lines
+1
to
+18
| # # This workflow uses actions that are not certified by GitHub. | ||
| # # They are provided by a third-party and are governed by | ||
| # # separate terms of service, privacy policy, and support | ||
| # # documentation. | ||
| # | ||
| # # Sample workflow for building and deploying a Jekyll site to GitHub Pages | ||
| # name: Deploy Jekyll site to Pages preview environment | ||
| # on: | ||
| # # Runs on pull requests targeting the default branch | ||
| # pull_request_target: | ||
| # branches: ["main"] | ||
| # # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages | ||
| # permissions: | ||
| # contents: read | ||
| # pages: write | ||
| # id-token: write | ||
| # # Allow only one concurrent deployment per PR, skipping runs queued between the run in-progress and latest queued. | ||
| # # However, do NOT cancel in-progress runs as we want to allow these production deployments to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.