Skip to content

chore: retire iFlow CLI integration — product discontinued (#3166)#3211

Open
BenBtg wants to merge 2 commits into
mainfrom
chore/3166-retire-iflow
Open

chore: retire iFlow CLI integration — product discontinued (#3166)#3211
BenBtg wants to merge 2 commits into
mainfrom
chore/3166-retire-iflow

Conversation

@BenBtg

@BenBtg BenBtg commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closes #3166.

The iFlow CLI product was discontinued (maintenance stopped 2026-03-20, closed 2026-04-17), so this removes the dead integration.

Changes

  • Delete src/specify_cli/integrations/iflow/ subpackage
  • Remove import + _register() from integrations/__init__.py
  • Remove iflow from integrations/catalog.json
  • Remove iflow mapping from extensions/agent-context/agent-context-defaults.json
  • Remove rows from docs/reference/integrations.md
  • Delete tests/integrations/test_integration_iflow.py; drop iflow from test_registry.py and test_agent_config_consistency.py
  • Remove iFlow CLI from bug/feature/agent issue templates

CHANGELOG.md is intentionally untouched (auto-generated).

The registry + agent-config consistency suites pass. (The 10 failures in tests/extensions/test_extension_agent_context.py are a pre-existing bash syntax error in update-agent-context.sh on main, unrelated to this change.)


🤖 Opened by GitHub Copilot (model: Claude Opus 4.8) on behalf of @BenBtg.

@BenBtg BenBtg requested a review from mnriem as a code owner June 29, 2026 11:40
Copilot AI review requested due to automatic review settings June 29, 2026 11:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR retires the discontinued iFlow CLI integration by removing its integration subpackage and all related references across the integration registry, catalog, docs, tests, and GitHub issue templates.

Changes:

  • Removed the iflow integration implementation and unregistered it from the built-in integration registry.
  • Deleted/updated tests and documentation that referenced iflow, including the integration catalog entry.
  • Updated issue templates to stop presenting iFlow CLI as a supported agent option.
Show a summary per file
File Description
tests/test_agent_config_consistency.py Removes iflow from agent-config and registrar consistency checks and expected agent key lists.
tests/integrations/test_registry.py Drops iflow from the required integration registry key list.
tests/integrations/test_integration_iflow.py Deletes the integration-specific test coverage for iFlow.
src/specify_cli/integrations/iflow/__init__.py Deletes the iFlow integration implementation.
src/specify_cli/integrations/__init__.py Removes import/registration of the iFlow integration from built-ins.
integrations/catalog.json Removes the iflow entry from the integrations catalog.
docs/reference/integrations.md Removes iFlow CLI from the supported integrations table and multi-install-safe list.
CHANGELOG.md Adds a changelog entry noting the iFlow integration retirement.
.github/ISSUE_TEMPLATE/feature_request.yml Removes iFlow CLI from the “affected agents” dropdown options.
.github/ISSUE_TEMPLATE/bug_report.yml Removes iFlow CLI from the “affected agents” dropdown options.
.github/ISSUE_TEMPLATE/agent_request.yml Removes iFlow CLI from the “currently supported agents” text list.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 11/11 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread CHANGELOG.md

- chore: retire iFlow CLI integration — product discontinued (#3166)


@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to CHANGELOG.md as it is automatically generated

Remove the iFlow CLI integration whose product was shut down: subpackage,
registry entry, catalog entry, docs, tests, and issue-template options.

Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BenBtg BenBtg force-pushed the chore/3166-retire-iflow branch from 6b3f274 to 173262c Compare June 29, 2026 14:09
@BenBtg

BenBtg commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks — reverted the CHANGELOG.md change (amended the commit, force-pushed). Applied the same revert across the sibling PRs in this batch (#3212, #3213, #3214, #3215, #3216) so none of them touch the auto-generated changelog. Re-requesting review.

Posted on behalf of @BenBtg by GitHub Copilot (model: Claude Opus 4.8, autonomous).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 10/10 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment on lines 63 to 67
from .gemini import GeminiIntegration
from .generic import GenericIntegration
from .goose import GooseIntegration
from .hermes import HermesIntegration
from .iflow import IflowIntegration
from .junie import JunieIntegration

@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback and update PR description to match

# Conflicts:
#	src/specify_cli/integrations/iflow/__init__.py
#	tests/integrations/test_integration_iflow.py
@BenBtg

BenBtg commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the review feedback:

  • Reverted CHANGELOG.md (it is auto-generated) and removed the stale "CHANGELOG entry" bullet from the PR description.
  • Resolved conflicts by merging main in (additive merge commit, no force-push). iFlow had moved on main, so I re-applied the removal and also caught a new touchpoint: the iflow mapping in extensions/agent-context/agent-context-defaults.json (added on main since this PR opened) is now removed too.
  • Updated the description to list the current, accurate set of changes.

Net diff is removal-only across the integration, catalog, docs, issue templates, and tests — CHANGELOG.md untouched. Commit: 1f5143a.

Note: the registry + agent-config consistency suites pass. The 10 failures in tests/extensions/test_extension_agent_context.py are a pre-existing bash syntax error in update-agent-context.sh on main (identical on this branch), unrelated to this change.

Posted on behalf of @BenBtg by GitHub Copilot (model: Claude Opus 4.8, autonomous).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 11/11 changed files
  • Comments generated: 0 new
  • Review effort level: Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire/remove iflow (iFlow CLI) integration — product discontinued

3 participants