fix: add timeout to run_command() to prevent indefinite hangs - #3964
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: add timeout to run_command() to prevent indefinite hangs#3964Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
Add a timeout parameter (default 120s) to subprocess.run() calls in run_command() utility. Previously, if a spawned process hung, the CLI would block forever with no way to recover. Also removes redundant hasattr(e, 'stderr') check on CalledProcessError which always has a stderr attribute when capture_output=True. Assisted-by: GitHub Copilot (model: mimo-v2-free, supervised)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a default timeout to prevent run_command() from hanging indefinitely.
Changes:
- Adds configurable 120-second timeout.
- Reports and re-raises timeout failures.
- Simplifies stderr handling.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_utils.py |
Adds subprocess timeout support and error reporting. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+109
to
+111
| except subprocess.TimeoutExpired: | ||
| console.print(f"[red]Command timed out after {timeout}s:[/red] {' '.join(cmd)}") | ||
| raise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
"run_command() utility called subprocess.run() without timeout. If a spawned process hangs, the CLI blocks forever.
Fix