fix: use logger instead of print() in events.py - #3965
Open
Quratulain-bilal wants to merge 1 commit into
Open
Conversation
…ts.py Replace print(..., file=sys.stderr) calls with logger.error()/warning() for consistent logging behavior. The module already defines logger = logging.getLogger(__name__) and uses it elsewhere, but three messages were using print() which bypasses logging configuration.
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces direct stderr printing with logging in event handling.
Changes:
- Logs dispatcher failures as errors.
- Logs unsupported integration events as warnings.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/events.py |
Updates event diagnostics to use logging. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+279
to
+282
| logger.error("Event %s timed out", command_name) | ||
| return 2 | ||
| except Exception as e: | ||
| print(f"Event {command_name} error: {e}", file=sys.stderr) | ||
| logger.error("Event %s error: %s", command_name, e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three error/warning messages in events.py used print(..., file=sys.stderr) instead of the module's existing logger, bypassing logging configuration.
Fix
Replace print() calls with logger.error()/logger.warning() for consistent logging behavior.