Fix extension skill command reference rendering - #4116
Open
WOLIKIMCHENG wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes literal slash-dot command references in generated extension skills.
Changes:
- Adds integration-specific command rendering.
- Preserves native, URL, bare, and selected file-like references.
- Adds tests and author guidance.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/__init__.py |
Normalizes literal command references. |
tests/test_extension_skills.py |
Tests invocation styles and exclusions. |
extensions/EXTENSION-USER-GUIDE.md |
Documents portable command references. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
src/specify_cli/extensions/init.py:1628
- The right boundary both accepts a following
/and rejects every following., so/speckit.foo.bar/scripts/run.shis incorrectly rewritten even though it is path-like, while the ordinary sentenceRun /speckit.foo.bar.is not rewritten at all. Reject/as a path continuation, but treat.as a continuation only when another identifier segment follows.
r"(?![A-Za-z0-9_.-])"
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+1613
to
+1620
| if command_name.rsplit(".", 1)[-1] in { | ||
| "json", | ||
| "md", | ||
| "toml", | ||
| "txt", | ||
| "yaml", | ||
| "yml", | ||
| }: |
mnriem
requested changes
Aug 14, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalizes literal slash-dot command references when extension commands are rendered into generated
SKILL.mdfiles for skills-based integrations.This keeps the existing
__SPECKIT_COMMAND_*__token path intact, and adds coverage for literal references such as/speckit.foo.barso generated extension skills use the active integration's invocation style ($speckit-foo-bar,/speckit-foo-bar, or/skill:speckit-foo-bar).Scope is limited to generated extension skills. Bare prose, native skill references, URLs, and file-like references are preserved.
Fixes #3451.
Testing
.venv/bin/python -m pytest tests/test_extension_skills.py -q.venv/bin/python -m pytest tests/test_agent_config_consistency.py -qUV_CACHE_DIR=/tmp/spec-kit-uv-cache uvx ruff@0.15.0 check src testsgit diff --check -- src/specify_cli/extensions/__init__.py tests/test_extension_skills.py extensions/EXTENSION-USER-GUIDE.md