test(mocks): pin electron mock shapes via satisfies Pick#2846
Merged
Conversation
Wraps each vi.mock('electron', ...) factory with satisfies Pick<Electron.X, '...'> on every mocked namespace, so any drift between the mock and Electron's real type signatures fails at tsc time. Caught two pre-existing drifts: showMessageBox missing checkboxChecked, and ipcRenderer.on returning void instead of IpcRenderer.
|
setchy
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generalises the PR #2839 safety pattern (
satisfies Pick<SafeStorage, …>onstorage.test.ts) to every othervi.mock('electron', …)factory in the test suite. Any future drift between a mocked Electron API and its real signature now failstsc.Already paid off: the new constraint surfaced two real, pre-existing mock drifts that this PR fixes:
dialog.showMessageBoxmock returned{response}instead of{response, checkboxChecked}.ipcRenderer.onmock returnedvoidinstead ofIpcRenderer(chainable).Verified
pnpm tsc --noEmit— clean.pnpm test— 938/938 (renderer route timeouts are a preexisting flake; pass on retry).globalShortcut.registerto return a string —tscerrors withType 'Mock<() => string>' is not assignable to type '(accelerator: string, callback: () => void) => boolean'.