fix(popups): command-bar toggle ([.]) works inside diff/commit viewer popups#2999
Open
stevenpollack wants to merge 1 commit into
Open
fix(popups): command-bar toggle ([.]) works inside diff/commit viewer popups#2999stevenpollack wants to merge 1 commit into
stevenpollack wants to merge 1 commit into
Conversation
…wers The Inspect Commit, Compare, File History and Blame popups consumed every key while open (a blanket `EventState::Consumed`), so the command bar `more`/`less` toggle ([.]) never reached the app-level handler and did nothing inside them. Pass the cmd_bar_toggle key through (`NotConsumed`) so it bubbles up. None of these popups host a text input, so this cannot hijack typing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
stevenpollack
added a commit
to stevenpollack/gitui
that referenced
this pull request
Jul 15, 2026
Patch bump for the command-bar toggle fix in the diff/commit viewer popups (upstream PR gitui-org#2999). Cut the changelog Unreleased entries under [0.31.1]. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LrbVApNVj46mmVyzfqgDsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Inspect Commit, Compare, File History and Blame popups consume every key while open (a blanket
return Ok(EventState::Consumed)at the end of theirevent()), so the command barmore/lesstoggle (.,cmd_bar_toggle) never reaches the app-level handler inApp::eventand does nothing inside those popups.Fix
Pass the
cmd_bar_togglekey through (NotConsumed) at the top of each of those four popups' key handling, so it bubbles up to the existing app-level toggle. Everything else stays modal.These popups host no text input, so letting
.through can't hijack typing.Before / after
.— the command bar never expands, even thoughmore [.]is shown..togglesmore/lessin all four viewers, matching the behaviour in the main tabs.🤖 Generated with Claude Code