fix: support AltGr text input on Windows#3000
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2848.
On Windows, crossterm reports AltGr as Ctrl+Alt.
TextInputComponentrejected every event with the Alt modifier, so AltGr-bound characters such as{,[,],}, and\could not be entered in commit messages or other text inputs.Handle Ctrl+Alt character events as text after the existing Ctrl+Alt editing shortcuts have had a chance to match. This preserves commands such as Ctrl+Alt+B while accepting characters that are not shortcut bindings.
Tests
cargo test --no-default-features --features regex-fancy(80 passed)rustfmt --check src/components/textinput.rsgit diff --checkThe default-feature build could not run on this Windows host because its vendored OpenSSL dependency requires Perl, which is not installed. The code path was fully validated under the project's non-vendored feature combination.