CFDictionary: cover creation, query and add/replace semantics#72
Open
DTW-Thalion wants to merge 1 commit into
Open
CFDictionary: cover creation, query and add/replace semantics#72DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
The existing tests drive the mutable set/get/remove path but leave the immutable and query API untested. Add a suite that exercises CFDictionaryCreate, CFDictionaryCreateCopy and CFDictionaryCreateMutableCopy, the query functions (CFDictionaryContainsKey/Value, GetCountOfKey/Value, GetKeysAndValues, GetValueIfPresent), CFDictionaryApplyFunction, the type ID, and CFEqual / CFHash. A second file covers the add/set/replace distinction: CFDictionaryAddValue leaves a present key untouched, while CFDictionarySetValue overwrites and CFDictionaryReplaceValue only acts on a present key. Raises CFDictionary.c line coverage from 71.7% to 80.3% (the remainder is the toll-free-bridge paths).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing CFDictionary tests drive the mutable set/get/remove path (and a large stress test) but leave the immutable and query API untested. This adds two files to
Tests/CFDictionary.create.m— immutable and read-only API:CFDictionaryCreate,CFDictionaryCreateCopy.CFDictionaryContainsKey,CFDictionaryContainsValue,CFDictionaryGetCountOfKey,CFDictionaryGetCountOfValue(including a value shared by two keys),CFDictionaryGetKeysAndValues,CFDictionaryGetValueIfPresent.CFDictionaryApplyFunction(verifies every entry is visited).CFDictionaryGetTypeID/CFGetTypeID, andCFEqual/CFHash.mutation.m— the add/set/replace distinction:CFDictionaryAddValueleaves a key that is already present untouched, whereasCFDictionarySetValueoverwrites andCFDictionaryReplaceValueacts only on a present key.CFDictionaryCreateMutableCopy,CFDictionaryRemoveValue,CFDictionaryRemoveAllValues.Raises
CFDictionary.cline coverage from 71.7% to 80.3% (measured with llvm-cov). All new tests pass and no existing tests are affected. The remaining uncovered lines are the toll-free-bridge (CF_IS_OBJC) branches, which pure-CF tests do not reach.