Skip to content

Add go-git integration test#207

Closed
pjbgf wants to merge 1 commit into
mainfrom
v6-improvements
Closed

Add go-git integration test#207
pjbgf wants to merge 1 commit into
mainfrom
v6-improvements

Conversation

@pjbgf
Copy link
Copy Markdown
Member

@pjbgf pjbgf commented May 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2026 14:03
Comment thread .github/workflows/go-git-integration.yml Dismissed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to run go-git’s test suite against the PR’s go-billy code, and updates the osfs BoundOS implementation/tests to correctly handle Windows drive-qualified absolute paths (needed for go-git + util helpers on Windows).

Changes:

  • Add a new go-git-integration.yml workflow that checks out go-billy + go-git and runs go test ./... (and CLI tests when present) across Linux/macOS/Windows.
  • Update BoundOS.absNoFollow / BoundOS.secureJoin to recognize and correctly join Windows drive-qualified absolute paths when the filesystem is rooted at the Windows host root.
  • Add Windows-only tests for drive-qualified absolute paths and util.TempDir behavior on osfs.Default.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
osfs/os_bound.go Adds Windows host-root drive path splitting and uses it in join/abs logic to support C:\... / UNC paths correctly.
osfs/os_bound_test.go Adds Windows-only regression tests validating drive-qualified absolute paths and util.TempDir usage with osfs.Default.
.github/workflows/go-git-integration.yml Introduces a go-git integration workflow that runs go-git (and CLI) tests against the local go-billy checkout on 3 OSes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/go-git-integration.yml
Comment thread .github/workflows/go-git-integration.yml
Comment thread .github/workflows/go-git-integration.yml
Signed-off-by: Paulo Gomes <paulo@entire.io>
@pjbgf pjbgf force-pushed the v6-improvements branch from b342d93 to 422f353 Compare May 8, 2026 12:37
@pjbgf pjbgf closed this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants