Add go-git integration test#207
Closed
pjbgf wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to run go-git’s test suite against the PR’s go-billy code, and updates the osfs BoundOS implementation/tests to correctly handle Windows drive-qualified absolute paths (needed for go-git + util helpers on Windows).
Changes:
- Add a new
go-git-integration.ymlworkflow that checks out go-billy + go-git and runsgo test ./...(and CLI tests when present) across Linux/macOS/Windows. - Update
BoundOS.absNoFollow/BoundOS.secureJointo recognize and correctly join Windows drive-qualified absolute paths when the filesystem is rooted at the Windows host root. - Add Windows-only tests for drive-qualified absolute paths and
util.TempDirbehavior onosfs.Default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
osfs/os_bound.go |
Adds Windows host-root drive path splitting and uses it in join/abs logic to support C:\... / UNC paths correctly. |
osfs/os_bound_test.go |
Adds Windows-only regression tests validating drive-qualified absolute paths and util.TempDir usage with osfs.Default. |
.github/workflows/go-git-integration.yml |
Introduces a go-git integration workflow that runs go-git (and CLI) tests against the local go-billy checkout on 3 OSes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Paulo Gomes <paulo@entire.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.