Skip to content

Implement io.ReaderAt and io.Seeker for iofs adapter#208

Merged
pjbgf merged 1 commit into
go-git:mainfrom
evankanderson:add-io-readat
May 7, 2026
Merged

Implement io.ReaderAt and io.Seeker for iofs adapter#208
pjbgf merged 1 commit into
go-git:mainfrom
evankanderson:add-io-readat

Conversation

@evankanderson
Copy link
Copy Markdown
Contributor

Per [io.fs/File documentation](https://pkg.go.dev/io/fs#File):

A file may implement io.ReaderAt or io.Seeker as optimizations.

I'm trying to use go-billy to present a virtual filesystem to https://github.com/google/osv-scalibr, and (one!) of the plugins attempts to use io.ReaderAt and fails otherwise. Since this is just a matter of plumbing, I added the methods as pass-throughs.

Copilot AI review requested due to automatic review settings May 6, 2026 16:33
Copy link
Copy Markdown
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evankanderson thanks for working on this. 🙇

@pjbgf pjbgf merged commit 8db9859 into go-git:main May 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants