fix(checkout): only require name for free pickup orders#1368
Open
nlaverde-godaddy wants to merge 2 commits intogodaddy:mainfrom
Open
fix(checkout): only require name for free pickup orders#1368nlaverde-godaddy wants to merge 2 commits intogodaddy:mainfrom
nlaverde-godaddy wants to merge 2 commits intogodaddy:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3b5eb12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nlaverde-godaddy
force-pushed
the
vnext-79361
branch
from
e10c7bb to
edae64d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "Complete your free order" button not working for free pickup orders.
Problem
When a customer had a free order with PICKUP delivery, clicking "Complete your free order" did nothing. The form validation required full billing address fields, but those fields weren't visible in the UI, causing silent validation failure.
Solution
paymentMethod === 'offline'+deliveryMethod === 'PICKUP'), only requirebillingFirstNameandbillingLastNameChanges
checkout.tsx- Updated Zod schema validation to handle free pickup casecustom-form-provider.tsx- Updated field filtering logic for validationfree-payment-form.tsx- Added name input fields for pickup ordersfree-payment-form.test.ts- Added unit tests for billing validation logicTesting
free payment and pickup upder:
Related
VNEXT-79361