feat(pkg): add go-import pages for cloudsql, influxdb, and kv-store/dynamodb#222
Merged
Merged
Conversation
…ynamodb These three datasource modules were tagged and available via go get but missing the vanity import redirect pages, causing go get to return 404 and fall back to the root gofr.dev module. Also adds CloudSQL to the datasource navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three datasource modules had published tags but
go getfails for them because gofr.dev returns 404 on their vanity import paths — Go's toolchain can't find thego-importmeta tag and falls back to the root module.Changes
Adds
layout.jsx+page.jsxfor three missing datasource modules and adds Cloud SQL to the navigation.Release notes
Cloud SQL —
gofr.dev/pkg/gofr/datasource/cloudsqlv0.1.0 (new)New datasource that connects GoFr applications to Google Cloud SQL (Postgres/MySQL) with GCP IAM database authentication — no static DB password, no Cloud SQL Auth Proxy sidecar. Controlled by the
DB_IAM_AUTHconfig key; when off, it delegates to the standard SQL path, so the sameapp.AddSQLDB(cloudsql.New(app.Config))line works identically in local and cloud environments.Credentials resolve via Application Default Credentials (supports Workload Identity Federation). The module lives in its own
go.modso only apps that import it pull thecloudsqlconnand GCP SDK — no new dependencies land in the core module.InfluxDB —
gofr.dev/pkg/gofr/datasource/influxdbv0.1.1 (patch)DynamoDB —
gofr.dev/pkg/gofr/datasource/kv-store/dynamodbv0.1.1 (patch)Test plan
go get gofr.dev/pkg/gofr/datasource/cloudsql@v0.1.0resolves correctlygo get gofr.dev/pkg/gofr/datasource/influxdb@v0.1.1resolves correctlygo get gofr.dev/pkg/gofr/datasource/kv-store/dynamodb@v0.1.1resolves correctlygofr.dev/pkg/gofr/datasource/cloudsql?go-get=1returns HTTP 200 withgo-importmeta tag