v0.27.4: goffi v0.5.1, flaky test fix, CGO_ENABLED=1 support#178
Merged
Conversation
Replace time.Sleep(10ms) with channel-based synchronization. Same pattern as f940eb7 (SnatchLock fix) — deterministic wait instead of timing-dependent sleep on slow CI runners. Verified: 100/100 passes with -count=100.
…=1 support goffi v0.5.1: struct by-value ABI, XMM return (Metal NSPoint/CGSize), callback struct args, CGO_ENABLED=1 (race detector). x/sys v0.43.0 → v0.44.0.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestThread_CallAsyncon Windows CI — channel sync replacestime.Sleep(10ms), deterministic (100/100 passes with-count=100)CGO_ENABLED=1support (race detector)Test plan
go test -count=100 ./internal/thread/— 100/100 passesgo build ./...— Windows, Linux, macOSgolangci-lint run --timeout=5m— 0 issuesgo test ./...— all pass