Skip to content

feat: hand-written lessons 13-25 with topic-bound practice - #17

Merged
gon7187 merged 3 commits into
mainfrom
feat/rewrite-lessons-13-25
Jul 28, 2026
Merged

feat: hand-written lessons 13-25 with topic-bound practice#17
gon7187 merged 3 commits into
mainfrom
feat/rewrite-lessons-13-25

Conversation

@gon7187

@gon7187 gon7187 commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Что сделано

Уроки 13-25 вынесены из шаблонной генерации в рукописные (новый модуль app/lessons_13_25.py, 902 строки). Генератор extended_curriculum.py покрывает только 26-120.

Причина (лечение «стены»)

4 независимых ревью показали: теория уроков 13+ = 1 предложение (~265 символов), практика не по теме (16 уникальных задач на 108 уроков). Ученик-новичок застрял на этом блоке.

Каждый урок 13-25

  • Одно измеримое умение
  • 3 разные карточки теории с примерами И показанным выводом
  • Разбор типичной ошибки новичка
  • Код-задача строго на тему урока (14→// и %, 15→and/or/not, 16→round/float, 17→срезы, 18→find/replace/in, 19→split/join, 20→форматирование, 22→распаковка, 23→срезы списков, 24→zip/enumerate, 25→методы списка)
  • Choice с правдоподобными дистракторами по теме

Совместимость

  • Сохранены lesson_id, module_id, order — прогресс и экзамены не сломаны
  • 15 pytest passed
  • Контент-ревью Claude Sonnet: в процессе

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbfc74c518

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/lessons_13_25.py
Comment on lines +260 to +264
[
{
"kind": "call",
"call": "can_enter(20, True, False, False)",
"expected": True,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a no-ticket case to the can_enter tests

Every test invokes can_enter with has_ticket=True, so a solution that completely omits the required ticket check—such as return (age >= 18 or with_adult) and not is_blocked—is marked correct. Add at least one otherwise-eligible, unblocked case with has_ticket=False and an expected result of False so learners cannot pass without implementing this stated condition.

Useful? React with 👍 / 👎.

@gon7187
gon7187 merged commit 4c8ea47 into main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant