feat: auto-load staging secrets from .env and fix DS_PASSWORD plumbing#1481
Open
feat: auto-load staging secrets from .env and fix DS_PASSWORD plumbing#1481
Conversation
tychtjan
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
tychtjan
force-pushed
the
JTYC-STAGING-CHANGES
branch
from
ad5801f to
27e1cb5
Compare
jaceksan
requested changes
Mar 24, 2026
tychtjan
force-pushed
the
JTYC-STAGING-CHANGES
branch
6 times, most recently
from
5af9c61 to
54ecbf5
Compare
Also fix __func__ attribute error on staticmethod in conftest for Python 3.10+, relax VCR matchers to support both local and staging cassettes, and relax organization assertions for dual-environment cassette support.
tychtjan
force-pushed
the
JTYC-STAGING-CHANGES
branch
from
54ecbf5 to
538a05e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
=======================================
Coverage 77.31% 77.31%
=======================================
Files 227 227
Lines 14761 14761
=======================================
Hits 11413 11413
Misses 3348 3348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.envauto-loading: Staging make targets now readSTAGING_ADMIN_TOKENandSTAGING_DS_PASSWORDfrom.envvia Make's-includeproject_common.mk→tox.ini→conftest.py→upload_demo_layout.py_patch_ds_credentialsfixture overridesdemo-test-dspassword in memory instead of rewriting the YAML file__func__fix:staticmethodaccess changed for Python 3.10+ compatibility (no more__func__attribute)scheme,host,portfrom cassette matching so cassettes recorded on either local or staging work in CI_default_organization_checknow asserts fields are populated rather than matching exact config values, enabling dual-environment cassette supportgooddata-api-clientand OpenAPI schemasjira: DX-341
risk: low