feat: add version_file input to read the gcloud version from a file#736
Open
somaz94 wants to merge 1 commit into
Open
feat: add version_file input to read the gcloud version from a file#736somaz94 wants to merge 1 commit into
somaz94 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
version_fileinput that resolves the Cloud SDK version from a file, mirroring the*-version-filepattern inactions/setup-go,actions/setup-node, andactions/setup-python.Two formats are supported:
416.0.0or>= 416.0.0).tool-versionsfile containing agcloud <version>linePrecedence: an explicitly set
version(anything other than the defaultlatest) wins andversion_fileis ignored with a warning. The version-resolution logic is unchanged once a concrete version is determined, so the existing install/cache path is reused as-is.Validation (run locally):
npm run lint(eslint) passesnpm testpasses, 22/22 (added 3run()cases for.tool-versions/ plain file /versionprecedence, plus 5parseVersionFileunit cases)npm run build(ncc) rebuiltdist/index.jsnpm run docsregenerated the README inputs section