Skip to content

Add gcloud authentication prerequisites to Cloud Run deployment guide#1341

Open
selamw1 wants to merge 3 commits intogoogle:mainfrom
selamw1:deploy-auth-prerequisites
Open

Add gcloud authentication prerequisites to Cloud Run deployment guide#1341
selamw1 wants to merge 3 commits intogoogle:mainfrom
selamw1:deploy-auth-prerequisites

Conversation

@selamw1
Copy link
Copy Markdown
Collaborator

@selamw1 selamw1 commented May 6, 2026

Description

Adds a Prerequisites section to the Cloud Run deployment README.md to guide users through setting up authentication and enabling APIs before running the deploy.sh script. This prevents script failures due to missing active credentials or disabled APIs.

The guide now covers:

  1. Authenticating via gcloud auth login.
  2. Setting up Application Default Credentials via gcloud auth application-default login.
  3. Enabling required run.googleapis.com and discoveryengine.googleapis.com APIs.

Fixes #1271

Pre-launch Checklist

  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I read the [Style Guide].
  • I have added updates to the [CHANGELOG].
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.
  • If my branch is on fork, I have verified that scripts/e2e_test.sh passes.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the CSS reset in the React renderer to exclude SVG elements and their descendants, restoring proper SVG rendering. It also adds a new unit test and updates the CHANGELOG. In the documentation, a prerequisites section was added to the Cloud Run sample README. Feedback highlights a major issue where a large portion of the README was accidentally deleted and a code block was left unclosed. Additionally, the reviewer noted a mismatch between the PR description and the functional changes, an incorrect issue reference in the CHANGELOG, and suggested improving the unit test by verifying computed styles.

Comment thread samples/agent/adk/gemini_enterprise/cloud_run/README.md Outdated
Comment thread renderers/react/CHANGELOG.md Outdated
Comment thread renderers/react/tests/v0_8/unit/components/SvgReset.test.tsx Outdated
@selamw1 selamw1 force-pushed the deploy-auth-prerequisites branch 2 times, most recently from 9014bef to 17816ea Compare May 6, 2026 00:42
@selamw1 selamw1 force-pushed the deploy-auth-prerequisites branch from 17816ea to 478b5a6 Compare May 6, 2026 00:47
@selamw1 selamw1 force-pushed the deploy-auth-prerequisites branch from a94f22a to 023839e Compare May 6, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

cloud run docs: Add authentication prerequisites to deployment guide

1 participant