Add gcloud authentication prerequisites to Cloud Run deployment guide#1341
Open
selamw1 wants to merge 3 commits intogoogle:mainfrom
Open
Add gcloud authentication prerequisites to Cloud Run deployment guide#1341selamw1 wants to merge 3 commits intogoogle:mainfrom
selamw1 wants to merge 3 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the CSS reset in the React renderer to exclude SVG elements and their descendants, restoring proper SVG rendering. It also adds a new unit test and updates the CHANGELOG. In the documentation, a prerequisites section was added to the Cloud Run sample README. Feedback highlights a major issue where a large portion of the README was accidentally deleted and a code block was left unclosed. Additionally, the reviewer noted a mismatch between the PR description and the functional changes, an incorrect issue reference in the CHANGELOG, and suggested improving the unit test by verifying computed styles.
9014bef to
17816ea
Compare
17816ea to
478b5a6
Compare
a94f22a to
023839e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Prerequisites section to the Cloud Run deployment
README.mdto guide users through setting up authentication and enabling APIs before running thedeploy.shscript. This prevents script failures due to missing active credentials or disabled APIs.The guide now covers:
gcloud auth login.gcloud auth application-default login.run.googleapis.comanddiscoveryengine.googleapis.comAPIs.Fixes #1271
Pre-launch Checklist