Skip to content

test: increase timeout duration to 30 seconds for restaurant finder e… #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sugoi-yuzuru wants to merge 1 commit into from
Closed

test: increase timeout duration to 30 seconds for restaurant finder e… #1370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions samples/client/flutter/restaurant_finder/e2e_test/test/test_infra/restaurant_finder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,15 @@ final class TestRestaurantFinderClient {
expect(response, contains('A2UI'));
print('\nReceived agent card:\n$response\n');
},
timeout: const Duration(seconds: 30),
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request description is incomplete and the pre-launch checklist has not been filled out. According to the Repository Style Guide (Rule 18), PR descriptions should include the Pre-Review Checklist with all steps completed. Please update the description to provide context for the changes and confirm that all necessary steps (such as signing the CLA and verifying tests) have been taken.

References
  1. PR descriptions should include the Pre-Review Checklist from the PR template, with all of the steps completed. (link)

),
ShellProbe(
command: _restaurantFinderCurlMessage,
responseChecker: (response) {
expect(response, contains('"parts":[{"kind":'));
print('\nReceived agent response:\n$response\n');
},
timeout: const Duration(seconds: 30),
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The timeout duration const Duration(seconds: 30) is hardcoded and duplicated here and on line 70. To improve maintainability and follow the existing pattern in this file (where URLs and commands are defined as constants), consider defining a single constant for the probe timeout at the top of the file.

),
],
);
Expand Down
Loading