Skip to content

feat: Add a new local A2UI JSON viewer in the shell app.#1381

Open
dmandar wants to merge 1 commit intomainfrom
feature/local-uploader-polishing
Open

feat: Add a new local A2UI JSON viewer in the shell app.#1381
dmandar wants to merge 1 commit intomainfrom
feature/local-uploader-polishing

Conversation

@dmandar
Copy link
Copy Markdown
Collaborator

@dmandar dmandar commented May 8, 2026

Description

Also create sample A2UI JSON files to show up.
Can be opened with the ?/app=local query param after running shell app. e.g. http://localhost:5173/?app=local

image image

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

@github-project-automation github-project-automation Bot moved this to Todo in A2UI May 8, 2026
@dmandar dmandar requested review from gspencergoog and wrenj May 8, 2026 21:14
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a local offline previewer and prototyping tool, adding a file upload interface, built-in JSON samples, and a glassmorphic toast notification system. The A2UILayoutEditor component was updated with state management for local mode, enhanced styling, and logic to process local actions. Review feedback focuses on improving code quality and robustness, specifically by removing redundant whitespace, strengthening type safety for the markdown renderer, restoring encapsulation for the snackbar accessor, and refining the toast notification logic to prevent race conditions.

Comment thread samples/client/lit/shell/app.ts Outdated
Comment thread samples/client/lit/shell/app.ts Outdated
Comment thread samples/client/lit/shell/app.ts
Comment thread samples/client/lit/shell/app.ts Outdated
Comment thread samples/client/lit/shell/app.ts
@dmandar dmandar force-pushed the feature/local-uploader-polishing branch from 07381fe to 5d34926 Compare May 8, 2026 21:25
@dmandar dmandar force-pushed the feature/local-uploader-polishing branch from 5d34926 to b094c5e Compare May 8, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant