fix(tools): normalize tuple schemas for Gemini API#5800
Open
EaCognitive wants to merge 2 commits into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @EaCognitive, thank you for reopening this clean PR to fix the Cloud Run deployment issue #5428! While reviewing your PR against our contribution guidelines, we noticed a few items that could be added or updated to help speed up the review:
This information will help our reviewers review your PR more efficiently. Thanks again for your contribution! |
Collaborator
|
We switched to Gemini JSON schema by default so I don't think this PR is necessary because from_function_with_options is bypassed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening my fix for #5428 since the original issue was closed due to inactivity from the reporter.
My previous PR (#5446) accidentally included broken
cliandnoxfile.pyfiles which caused the CI failures. This is a clean submission containing ONLY the strip-based workaround verified to fix the Cloud Run deployment issues.Testing Plan
main.pre-commit run --all-filespasses format and license checks.tests/unittests/tools/test_function_parameter_parse_util.pyto verifyprefixItemsandunevaluatedItemsare successfully recursively stripped.Logs
cc @surajksharma07 @rohityan