-
Notifications
You must be signed in to change notification settings - Fork 170
Fix inverted null check in time_zone_name_win.cc
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| // Copyright 2026 Google Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "time_zone_name_win.h" | ||
|
|
||
| #include <string> | ||
|
|
||
| #include <windows.h> | ||
|
|
||
| #include "cctz/time_zone.h" | ||
| #include "gtest/gtest.h" | ||
|
|
||
| namespace cctz { | ||
|
|
||
| TEST(TimeZoneNameWin, GetWindowsLocalTimeZone) { | ||
| // On Windows 10 1809+ (where icu.dll is available in System32), | ||
| // GetWindowsLocalTimeZone() should return a valid IANA time zone name. | ||
| // Note that LOAD_LIBRARY_SEARCH_SYSTEM32 is not sufficient to reliably load | ||
| // "icu.dll" in the production code, but it should be OK for testing purposes. | ||
| HMODULE icu_dll = | ||
| ::LoadLibraryExW(L"icu.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32); | ||
| const std::string tz = GetWindowsLocalTimeZone(); | ||
| if (icu_dll != nullptr) { | ||
| EXPECT_FALSE(tz.empty()); | ||
| ::FreeLibrary(icu_dll); | ||
| } else { | ||
| EXPECT_TRUE(tz.empty()); | ||
| } | ||
|
Comment on lines
+34
to
+39
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My final question before handing off to @derekmauro. Do we know which branch our Windows CI actually takes? That is, is it checking that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should go to According to a recent run, runner image is
|
||
| } | ||
|
|
||
| } // namespace cctz | ||
Uh oh!
There was an error while loading. Please reload this page.