Skip to content

Update conformance test skip list #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −23
Open

Update conformance test skip list #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions conformance/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,26 +201,6 @@ _TESTS_TO_SKIP = [
# precision to preserve value. Not available on older compilers where we just use absl::Format.
# We should probably update the spec to allow different formats that parse to the same value.
"conversions/string/double_hard",

# Recent changes
"proto2/set_null/repeated_field_timestamp_null_pruned",
"proto2/set_null/repeated_field_duration_null_pruned",
"proto2/set_null/repeated_field_wrapper_null_pruned",
"proto2/set_null/map_timestamp_null_pruned",
"proto2/set_null/map_duration_null_pruned",
"proto2/set_null/map_wrapper_null_pruned",
"proto3/set_null/repeated_field_timestamp_null_pruned",
"proto3/set_null/repeated_field_duration_null_pruned",
"proto3/set_null/repeated_field_wrapper_null_pruned",
"proto3/set_null/map_timestamp_null_pruned",
"proto3/set_null/map_duration_null_pruned",
"proto3/set_null/map_wrapper_null_pruned",
"string_ext/format/default precision for fixed-point clause with int",
"string_ext/format/default precision for fixed-point clause with uint",
"string_ext/format/default precision for scientific notation with int",
"string_ext/format/default precision for scientific notation with uint",
"namespace/namespace_shadowing/basic",
"namespace/namespace_shadowing/comprehension_shadowing_namespaced_selector_disambiguation",
]

_TESTS_TO_SKIP_MODERN = _TESTS_TO_SKIP
Expand Down
6 changes: 3 additions & 3 deletions conformance/run.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _conformance_test_args(modern, optimize, recursive, select_opt, skip_check,
args.append("--skip_check")
else:
args.append("--noskip_check")
args.append("--skip_tests=\"{}\"".format(",".join(_expand_tests_to_skip(skip_tests))))
args.append("--skip_tests={}".format(",".join(_expand_tests_to_skip(skip_tests))))
if dashboard:
args.append("--dashboard")
return args
Expand All @@ -80,8 +80,8 @@ def _conformance_test(name, data, modern, optimize, recursive, select_opt, skip_
name = _conformance_test_name(name, optimize, recursive),
args = _conformance_test_args(modern, optimize, recursive, select_opt, skip_check, skip_tests, dashboard) + ["$(location " + test + ")" for test in data] + select(
{
"@platforms//os:windows": ["--skip_tests=\"{}\"".format(",".join(skip_tests + _TESTS_TO_SKIP_WINDOWS))],
"//conditions:default": ["--skip_tests=\"{}\"".format(",".join(skip_tests))],
"@platforms//os:windows": ["--skip_tests={}".format(",".join(skip_tests + _TESTS_TO_SKIP_WINDOWS))],
"//conditions:default": ["--skip_tests={}".format(",".join(skip_tests))],
},
),
data = data,
Expand Down